Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): make the case_sensitive field a boolean only #4128

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Wurstnase
Copy link
Contributor

Issue number: #4127

Summary

Changes

case_sensitive become bool only.

User experience

It seems to be weird that case_sensitive could be None. It is case_sensitive or not. There is no environment variable where we could have a default value.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@Wurstnase Wurstnase requested a review from a team as a code owner April 12, 2024 20:43
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2024
@Wurstnase Wurstnase changed the title fix: case_sensitive is never None fix(typing): case_sensitive is never None Apr 12, 2024
@rubenfonseca rubenfonseca linked an issue Apr 15, 2024 that may be closed by this pull request
@rubenfonseca rubenfonseca added the typing Static typing definition related issues (mypy, pyright, etc.) label Apr 15, 2024
@github-actions github-actions bot added the bug Something isn't working label Apr 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
20.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for CI to pass

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (e14e768) to head (c5dd3c2).
Report is 302 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4128      +/-   ##
===========================================
- Coverage    96.38%   96.25%   -0.13%     
===========================================
  Files          214      216       +2     
  Lines        10030    10393     +363     
  Branches      1846     1921      +75     
===========================================
+ Hits          9667    10004     +337     
- Misses         259      275      +16     
- Partials       104      114      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubenfonseca rubenfonseca changed the title fix(typing): case_sensitive is never None fix(typing): make the case_sensitive field a boolean only Apr 15, 2024
@rubenfonseca rubenfonseca added the event_sources Event Source Data Class utility label Apr 15, 2024
@rubenfonseca rubenfonseca merged commit 4e32f08 into aws-powertools:develop Apr 15, 2024
17 checks passed
@Wurstnase Wurstnase deleted the feat/typing branch April 15, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working event_sources Event Source Data Class utility size/M Denotes a PR that changes 30-99 lines, ignoring generated files. typing Static typing definition related issues (mypy, pyright, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static typing: case_sensitive should only be bool
3 participants