Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging AgentMetrics branch into dev #1745

Merged
merged 6 commits into from
Dec 14, 2018
Merged

Conversation

yhlee-aws
Copy link
Contributor

@yhlee-aws yhlee-aws commented Dec 14, 2018

Summary

Merging AgentMetrics branch into dev

Implementation details

dev branch has been rebased into AgentMetrics branch.

Testing

  • Builds on Linux (make release)
  • Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
  • Unit tests on Linux (make test) pass
  • Unit tests on Windows (go test -timeout=25s ./agent/...) pass
  • Integration tests on Linux (make run-integ-tests) pass
  • Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
  • Functional tests on Linux (make run-functional-tests) pass
  • Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes: Yes

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@petderek
Copy link
Contributor

Did you have to make any additional changes?

@yhlee-aws
Copy link
Contributor Author

this is what Kar had left, as-is.

Copy link
Contributor

@petderek petderek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhlee-aws yhlee-aws merged commit 421da2b into aws:dev Dec 14, 2018
@yhlee-aws yhlee-aws deleted the agent_metrics branch December 14, 2018 20:35
@pecigonzalo
Copy link

Is there a document of the exposed metrics?

@pecigonzalo
Copy link

Sorry to @ you guys, but this questions has been open for a while. @petderek @yunhee-l @yumex93

@yhlee-aws
Copy link
Contributor Author

Is there a document of the exposed metrics?

Hi @pecigonzalo,
This is not a feature that's been designed as customer facing, and hence there are no public documents on exposed metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants