Remove unused agent prometheus 'generic metrics' #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go mod tidy && go mod vendor
sparrc
force-pushed
the
rm-generic-metrics
branch
from
154dbac
to
2bb5286
Compare
sparrc
changed the title
amogh09
approved these changes
Jul 1, 2024
singholt
approved these changes
Jul 1, 2024
Ephylouise
pushed a commit
to Ephylouise/amazon-ecs-agent
that referenced
this pull request
Jul 2, 2024
go mod tidy && go mod vendor
Ephylouise
added a commit
to Ephylouise/amazon-ecs-agent
that referenced
this pull request
Jul 2, 2024
Add an echo to find where GO_VERSION is being retreived Remove else statement to check the if statement installs correct go version Add logic to retreive AL2023 version Remove quotes for variable definitions Move go and AL23 variables to install phase Remove trailing quotation mark for go variable Fix restartAttemptPeriod time.Duration/int parsing (aws#4218) * Fix restartAttemptPeriod time.Duration/int parsing * Fix TSS integ test that relied on mutable tag 3.19 is a changable tag that was recently updated to 3.19.2. Update test to use 3.19.1 as this tag should presumably never change it's digest. Add AL23 ref doc and install specific go version remove unused agent prometheus 'generic metrics' (aws#4225) go mod tidy && go mod vendor Add 4 new CodeBuild jobs to CloudFormation template for AL builds Replace RELEASE_COMMIT with GO_VERSION in Makefile Remove trailing space in original GOPATH if/then function Update pr-build.yml to modify go path logic Added an echo to check the github username. Removed the If/then statement that was creating the codebuild failures. GO path: remove if/then statement Correcting username syntax, capital letter This commit adds forked username to pr-build-ubuntu and echos go version Comment out golang dependency in ecs-agent.spec Add Windows make target in Makefile and pr-build.yml Create amzn2 and amzn23 buildspec files Add Windows Make target and comment out 'generic' build commands Fix indentation in amzn2/2023 buildspec files Add /out/ to Windows path in pr-build.yml Add line to echo the contents of expected artifact path Uncomment pr-build/agent.spec blocks, simplify sudo dnf update Add an 'automatic yes' to the version update pr-build-amzn2023.yml Edit file artifact variable name in amzn23 spec file Windows target to rely on inherent logic, add get-cni-sources to AL target
Ephylouise
added a commit
to Ephylouise/amazon-ecs-agent
that referenced
this pull request
Jul 2, 2024
Add an echo to find where GO_VERSION is being retreived Remove else statement to check the if statement installs correct go version Add logic to retreive AL2023 version Remove quotes for variable definitions Move go and AL23 variables to install phase Remove qtrailing quotation mark for go variable remove unused agent prometheus 'generic metrics' (aws#4225) go mod tidy && go mod vendor
Merged
jiuchoe4
pushed a commit
to saurabhc123/amazon-ecs-agent
that referenced
this pull request
Jul 12, 2024
go mod tidy && go mod vendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These metrics were added 6+ years ago in this PR. They were never really integrated throughout the agent nor documented. With the addition of pprof profiling into the agent, these stats have become somewhat more redundant.
Removing these now for the following reasons:
Testing
New tests cover the changes: no
Description for the changelog
Enhancement: Remove unused "generic metrics" code and processing
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.