Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFS Volume Configuration #2301

Merged
merged 7 commits into from
Dec 6, 2019
Merged

EFS Volume Configuration #2301

merged 7 commits into from
Dec 6, 2019

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Dec 4, 2019

Merging the efs volume config feature branch into dev. See PRs in commits below for more details.

sparrc and others added 7 commits December 5, 2019 15:28
* Added EFSVolumeConfiguration models

* Translate EFS volumes from ACS to Docker volume type

* fix gocyclo failure

* code review comments

* remove readonly config

* remove readonly options from code

* code review comments

* code review

* naming is hard
* Add efs client to Gopkg.*

* Add efs client to vendor directory

* EFS functional test

* Reuse EFS filesystem and mount target(s)

* review fixups

* more code review fixups
* EFSVolumeConfiguration -> efsVolumeConfiguration

* Fix FileSystemId and write json marshalling unit tests

* unit test PostUnmarshalTask efsVolumeConfiguration behavior

* windows unit test fix
@sparrc sparrc merged commit df03bef into dev Dec 6, 2019
@sparrc sparrc added this to the 1.35.0 milestone Dec 10, 2019
@petderek petderek mentioned this pull request Dec 11, 2019
@cyastella cyastella deleted the feature/efs-volume-config branch October 22, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants