Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.35.0 stage #2306

Merged
merged 13 commits into from
Dec 18, 2019
Merged

V1.35.0 stage #2306

merged 13 commits into from
Dec 18, 2019

Conversation

petderek
Copy link
Contributor

Summary

  • Feature - EFS Preview #2301
  • Bug - Load pause container for use by PID/IPC even if task networking is disabled #2300
  • Bug - Fixed a race condition that might cause the agent to crash during container creation #2299

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

amazon-ecs-bot and others added 13 commits November 25, 2019 21:40
Refactor the code to use goimports only and remove gofmt in makefile
This commits addresses the issue on aws#2290. Load pause container image by default. Enforce pid/ipc capabilities append to check for existence of pause container image
* Added EFSVolumeConfiguration (aws#2234)

* Added EFSVolumeConfiguration models

* Translate EFS volumes from ACS to Docker volume type

* fix gocyclo failure

* code review comments

* remove readonly config

* remove readonly options from code

* code review comments

* code review

* naming is hard

* Add efs capability (aws#2248)

* EFS functional testing (aws#2247)

* Add efs client to Gopkg.*

* Add efs client to vendor directory

* EFS functional test

* Reuse EFS filesystem and mount target(s)

* review fixups

* more code review fixups

* EFSVolumeConfiguration -> efsVolumeConfiguration (aws#2254)

* EFSVolumeConfiguration -> efsVolumeConfiguration

* Fix FileSystemId and write json marshalling unit tests

* unit test PostUnmarshalTask efsVolumeConfiguration behavior

* windows unit test fix

* Update ECS client and task defs (aws#2256)

* add memoryUnbounded to task volume marshal unit tests

* rebase mistake
AWS uses partitional endpoints for DNS domains. In standard partitions,
it will be 'amazonaws.com'; but other partitions use their own special
domains (eg, 'amazonaws.com.cn')

EFS doesn't currently support other partitions, but this should
future proof our client.
@petderek petderek added this to the 1.35.0 milestone Dec 12, 2019
@petderek petderek added the staging Trigger staging workflow label Dec 12, 2019
@@ -1,5 +1,10 @@
# Changelog

## 1.35.0
* Feature - EFS Preview [#2301](https://github.com/aws/amazon-ecs-agent/pull/2301)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EFS Storage Support Preview?

@amazon-ecs-bot amazon-ecs-bot merged commit 7fb1011 into aws:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Trigger staging workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.