-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.35.0 stage #2306
Merged
Merged
V1.35.0 stage #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go format check fix
Refactor the code to use goimports only and remove gofmt in makefile
This commits addresses the issue on aws#2290. Load pause container image by default. Enforce pid/ipc capabilities append to check for existence of pause container image
* Added EFSVolumeConfiguration (aws#2234) * Added EFSVolumeConfiguration models * Translate EFS volumes from ACS to Docker volume type * fix gocyclo failure * code review comments * remove readonly config * remove readonly options from code * code review comments * code review * naming is hard * Add efs capability (aws#2248) * EFS functional testing (aws#2247) * Add efs client to Gopkg.* * Add efs client to vendor directory * EFS functional test * Reuse EFS filesystem and mount target(s) * review fixups * more code review fixups * EFSVolumeConfiguration -> efsVolumeConfiguration (aws#2254) * EFSVolumeConfiguration -> efsVolumeConfiguration * Fix FileSystemId and write json marshalling unit tests * unit test PostUnmarshalTask efsVolumeConfiguration behavior * windows unit test fix * Update ECS client and task defs (aws#2256) * add memoryUnbounded to task volume marshal unit tests * rebase mistake
AWS uses partitional endpoints for DNS domains. In standard partitions, it will be 'amazonaws.com'; but other partitions use their own special domains (eg, 'amazonaws.com.cn') EFS doesn't currently support other partitions, but this should future proof our client.
mssrivas
approved these changes
Dec 11, 2019
yumex93
approved these changes
Dec 11, 2019
sharanyad
reviewed
Dec 12, 2019
@@ -1,5 +1,10 @@ | |||
# Changelog | |||
|
|||
## 1.35.0 | |||
* Feature - EFS Preview [#2301](https://github.com/aws/amazon-ecs-agent/pull/2301) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EFS Storage Support Preview
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.