Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ecs exec #2798

Merged
merged 51 commits into from
Jan 21, 2021
Merged

Feature/ecs exec #2798

merged 51 commits into from
Jan 21, 2021

Conversation

angelcar
Copy link
Contributor

Summary

Merge feature/ecs_exec into dev

Implementation details

Long story :) (you can see all the commits in the feature/ecs_exec feature branch)

Testing

Tested throughout the development of ecs exec command feature

New tests cover the changes: yes

Description for the changelog

Add Execute Command Agent Feature. This feature allows ECS customers to execute interactive commands inside containers.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fierlion and others added 30 commits January 20, 2021 13:38
@fierlion @angelcar
add TopContainer to dockerapi
880c298
@fierlion @angelcar
Rebase against dev branch
eb938f6
@sharanyad @angelcar
Add ps arguments to docker top to pass in process ID
26ef604
@ubhattacharjya @angelcar
Add docker exec create
a3b2a30
@ubhattacharjya @angelcar
Add ContainerExecStart to dockerapi
e6c7460
@ubhattacharjya @angelcar
add ContainerExecInspect to dockerapi
d87d6e7
@sharanyad @angelcar
monitor ExecAgent Processes for Exec-enabled tasks
a2009d4
@angelcar
Add integration tests for exec command agent
1a6658f
@angelcar
Remove unused config.Config argument in initializeExecCommandAgentRes…
75de50c 
…ources
@angelcar
Add exec subdirectory to exec command agent log path
050cde6
@angelcar
Remove ssm-session-logger from exec command agent requirements
a5791c1
@angelcar
Start exec command agent upon container startup
f78a3ff
@ubhattacharjya @angelcar
Add integration test for docker exec APIs
fff3e0e
@fierlion @angelcar
Add Container state change events for ManagedAgent.
6074f8b
@angelcar
Refactor PostUnmarshalTask to abstract away ExecCommandAgent complexity
d4bc3e8
@angelcar
Add integ test for ExecCommandAgent start, and monitor
0a56512
@sharanyad @angelcar
add jitter between monitoring exec agents for containers
98927d3
@fierlion @angelcar
add managedAgent event and update unit test (#2671)
1a92b58
@sharanyad @angelcar
cleanup ExecAgent host logs for exec tasks
9d39e38
@sharanyad @angelcar
Change ExecCommandAgentEnabled to ExecCommandAgentEnabledUnsafe
022090e
@sharanyad @angelcar
fix unit test failure
7449d97
@sharanyad @angelcar
add cleanup logs to integ test
02294da
@fierlion @angelcar
validate exec agent start container state change event (#2691)
fde9847
@sharanyad @angelcar
add helper methods for creating ExecAgent Config file
3da0878
@sharanyad @angelcar
generate execAgent config for default session limit
0fc85ac
@sharanyad @angelcar
change agent execute command dir
dc78868
@sharanyad @angelcar
change host execAgent config dir mount
40ccb8c
@sharanyad @angelcar
bind mount ExecAgent Config file to each container
0db867d
@angelcar
Refactor execute-command-agent start process to be done at container …
c27f22f 
…level
@angelcar
Fix exec command agent configuration template to make it valid JSON
1710ed8
angelcar and others added 21 commits January 20, 2021 13:38
@angelcar
Add util functions to determine latest ExecuteCommandAgent version
5476f76
@fierlion @angelcar
add managed agent stopped and running event check (#2702)
64faaf5
@cyastella @angelcar
add check for execute-command capability and populate attribute if ap…
41566e7 
…plicable (#2687)

* detect dependencies for SSM and add capability
* shorten name, update path, use test table
* shorten names for readability
* update check for ssm binaries
* only add folders with valid name
* add deny-list for ssm versions
* update comment
@angelcar
Use latest version available in deps bin dir
efe2f25
@angelcar
Fix exec command agent config
ed12294
@cyastella @angelcar
add helper function mockPathExists()
e29c1b5
@fierlion @angelcar
add select model updates from autogenerated model (#2723)
b752dc3
@sharanyad @angelcar
generate ExecAgent seelog config for exec enabled containers
3a21031
@sharanyad @angelcar
check the validity of exec agent config
1ca05f4
@angelcar
Add ManagedAgent changes to SubmitTaskStateChange
dc53b09
@fierlion @angelcar
update cert mount source (#2748)
0384f40
@sharanyad @angelcar
Cleanup config files paths if they are dirs
ccbbf07
@fierlion @angelcar
change to task level managed agent state change (#2758)
446304d
@ubhattacharjya @angelcar
Create container without enabling exec feature if exec bind mounting …
4a34811 
…fails.
@ubhattacharjya @angelcar
Emit managed agent stateChange event for Exec agent init failure
a9f9cc2
@cyastella @angelcar
check at least 1 ssm version is valid instad of checking all versions…
b68c37e 
… to advertise exec-enable (#2771)
@fierlion @angelcar
sync managed agent sent state (#2773)
24eb5e4
@angelcar
Emit ExecCommandAgent stop event when container stops
2023291
@angelcar
Emit the right reason upon exec command start error
68ab437
@sharanyad @angelcar
s/Execute Command Agent/ExecuteCommandAgent/g
60eb959
@ubhattacharjya @angelcar
Run ssm-agent with root user
4852969
@angelcar angelcar merged commit 7afe983 into dev Jan 21, 2021
@ubhattacharjya ubhattacharjya added this to the 1.50.0 milestone Jan 21, 2021
@briancurt
Copy link

Hello, is how to use this feature documented somewhere yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fierlion fierlion fierlion approved these changes

@ubhattacharjya ubhattacharjya ubhattacharjya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
7 participants
@angelcar @briancurt @fierlion @ubhattacharjya @amazon-ecs-bot @sharanyad @cyastella