Warm Pools Support #3123
Merged
Warm Pools Support #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being registered with the cluster
angelcar
approved these changes
Feb 2, 2022
YashdalfTheGray
approved these changes
Feb 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merging warm pools changes into dev. All changes already reviewed, see branch
feature/warm_pools(includes pr's #3032 #3055 #3078 #3081 ). This is related to issue #3000 , however the feature is currently in private preview only.Testing
See linked pr's for detailed testing. Testing has included manual tests and running internal testing suite while being allow-listed for EC2/Autoscaling changes.
New tests cover the changes: yes
Description for the changelog
prevent instances in EC2 Autoscaling warm pool from being registered with cluster
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.