V1.59.0 stage #3124
Merged
V1.59.0 stage #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3109) The acs/tacs endpoints that ecs agent connects have never changed before, so the current behavior of calling the API every 20 minutes is not necessary. Lengthening this cache TTL to 12 hours will reduce load on the ECS service and reduce the chance of customers being throttled. Additionally, the LRU cache we were using automatically evicted any value once it expired. This means that this API call could become a source of complete ecs agent failure in the event of an LSE, in the event that agent threw away it's cached endpoint and then failed to get a new one via DiscoverPollEndpoint. By keeping expired values in the cache, we can fallback to use the expired value in the event that the DiscoverPollEndpoint API is failing, thus keeping agent connected to ACS and TACS.
… being registered with the cluster (aws#3123) Co-authored-by: Lydia Filipe <fillydia@amazon.com>
angelcar
approved these changes
Feb 4, 2022
yinyic
approved these changes
Feb 4, 2022
fenxiong
approved these changes
Feb 4, 2022
shubham2892
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stage 1.59.0 release
Changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.