Merge Feature/task_scale_in_protection_pass_through to dev #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#3344) * Inject Agent API V1 endpoint path into containers as an environment variable * Swap expected and actual arguments to assert.Equal calls * Fix windows test Co-authored-by: Amogh Rathore <amoghr@amazon.com>
Update Task Scale In Protection Endpoint URI and handler to match latest decision.
Add String method to TaskProtection type
…ion Call (#3397) * Create ECS client for task protection and Implement UpdateTaskProtection Call
* Implement GetTaskProtection Call
* update task protection responses format * Remove ExpiresInMinutes validation, remove unnecessary types and marshal functions * Remove failure handling - instead of returning 4XX http status code, return 200 instead
singholt
approved these changes
Oct 11, 2022
amogh09
approved these changes
Oct 12, 2022
|
Has anyone reported issues with this change? We've noticed that since November 13th our ECS cluster's have been more aggressive in scaling down the nodes (instances). I'm just tracing this with release notes and similar feature scope. I can give more details privately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge feature/task_scale_in_protection_pass_through branch to dev branch.
Implementation details
Testing
New tests cover the changes: Yes
We also have new end2end test in functional test platform, as well as load test done for this feature.
Description for the changelog
Task Scale In Protection Pass Through Mode Agent side changes.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.