fix PR git-secret scan workflow #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
force-pushed
the
dev
branch
4 times, most recently
from
01477a0 to
37e215f
Compare
ubhattacharjya
previously approved these changes
Oct 21, 2022
chienhanlin
previously approved these changes
Oct 21, 2022
singholt
dismissed stale reviews from chienhanlin and ubhattacharjya
via
134cca0
chienhanlin
approved these changes
Oct 21, 2022
fierlion
approved these changes
Oct 21, 2022
sparrc
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There seems to be an issue with git-secrets complaining about not being able to find
say.example PR failure: https://github.com/aws/amazon-ecs-agent/actions/runs/3300364593/jobs/5444976040
This adds a workaround until this is fixed upstream: awslabs/git-secrets#221
Implementation details
Created a symbolic link between
sayandecho. Inspired by how the community is dealing with this, example: determined-ai/determined#5313Testing
New tests cover the changes: no
Description for the changelog
Workaround git-secrets scan issue: awslabs/git-secrets#221
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.