Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix missing say command #5313

Merged
merged 1 commit into from
Oct 21, 2022
Merged

ci: fix missing say command #5313

merged 1 commit into from
Oct 21, 2022

Conversation

rb-determined-ai
Copy link
Contributor

No description provided.

@rb-determined-ai rb-determined-ai requested a review from a team as a code owner October 21, 2022 15:38
@cla-bot cla-bot bot added the cla-signed label Oct 21, 2022
@netlify
Copy link

netlify bot commented Oct 21, 2022 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 5358658
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6352bd54497dae0009387871

@netlify
Copy link

netlify bot commented Oct 21, 2022 •
edited
Loading

✅ Deploy Preview for storybook-det canceled.

Name Link
🔨 Latest commit 5358658
🔍 Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/6352bd547edd0100080ebbe5

dannysauer
dannysauer approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine - but probably oughtta do the same thing for the identical check in .circleci/config

@dannysauer
Copy link
Contributor

dannysauer commented Oct 21, 2022 •
edited
Loading

Ok; I won't ask how this is continuing to work without the same workaround in the circleci environment. #SeeNoEvil

Also, adding a link to awslabs/git-secrets#221

@rb-determined-ai rb-determined-ai merged commit c711c43 into determined-ai:master Oct 21, 2022
@rb-determined-ai rb-determined-ai deleted the say branch October 21, 2022 16:38
@singholt singholt mentioned this pull request Oct 21, 2022
Merged
@sparr
Copy link

sparr commented Jun 20, 2023 •
edited
Loading

awslabs/git-secrets#221 fixes this upstream and has been merged. You should be able to remove your workaround if you update your pull to the master branch, or to our next release as soon as it's available.

@dannysauer dannysauer added this to the 0.19.7 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannysauer dannysauer dannysauer approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.19.7
Development

Successfully merging this pull request may close these issues.
3 participants
@rb-determined-ai @dannysauer @sparr