go mod and vendor update #3534
Merged
go mod and vendor update #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
go-mod-tidy-vendor-v2
branch
7 times, most recently
from
7b48915
to
3d93e35
Compare
sparrc
force-pushed
the
go-mod-tidy-vendor-v2
branch
from
add7c07
to
3d93e35
Compare
sparrc
force-pushed
the
go-mod-tidy-vendor-v2
branch
10 times, most recently
from
107ea3e
to
a92871b
Compare
sparrc
commented
Jan 25, 2023
| @@ -24,18 +25,14 @@ jobs: | |||
| echo "invalid GO version" | |||
| exit 1 | |||
| fi | |||
| echo "::set-output name=GO_VERSION::$go_version" | |||
| - uses: actions/setup-go@v2 | |||
| echo "GO_VERSION=$go_version" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
this is incorporating part of the change from #3487
sparrc
force-pushed
the
go-mod-tidy-vendor-v2
branch
from
a92871b
to
4ddf38b
Compare
sparrc
commented
Jan 25, 2023
| @@ -149,16 +149,15 @@ ifneq (${BUILD_PLATFORM},aarch64) | |||
| endif | |||
|
|
|||
| test: | |||
| ${GOTEST} -tags unit -coverprofile cover.out -timeout=60s ./agent/... | |||
| cd agent && GO111MODULE=on ${GOTEST} ${VERBOSE} -tags unit -mod vendor -coverprofile ../cover.out -timeout=60s ./... && cd .. | |||
There was a problem hiding this comment.
updating to latest go version in the modules file requires us to fully buy-in to modules here, so that is why these make targets are being updated.
chienhanlin
approved these changes
Jan 25, 2023
mythri-garaga
approved these changes
Jan 25, 2023
sparrc
added a commit
that referenced
this pull request
Jan 26, 2023
TestSquidProxy functional test is failing 100% of the time on this commit. Reverting to investigate why this test is failing. This reverts commit b019481.
sparrc
added a commit
to sparrc/amazon-ecs-agent
that referenced
this pull request
Jan 27, 2023
* go mod and vendor update * unit test upd * go mod tidy, go mod vendor on mac * try to fix windows winio dependency change in docker lib * hack: fix windows build * upgrade containernetworking/plugins * resolve some accidental downgrades * fix github actions
sparrc
added a commit
to sparrc/amazon-ecs-agent
that referenced
this pull request
Jan 28, 2023
* go mod and vendor update * unit test upd * go mod tidy, go mod vendor on mac * try to fix windows winio dependency change in docker lib * hack: fix windows build * upgrade containernetworking/plugins * resolve some accidental downgrades * fix github actions
sparrc
added a commit
that referenced
this pull request
Jan 30, 2023
* go mod and vendor update * unit test upd * go mod tidy, go mod vendor on mac * try to fix windows winio dependency change in docker lib * hack: fix windows build * upgrade containernetworking/plugins * resolve some accidental downgrades * fix github actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Diffs of direct dependencies in go.mod file:
awslabs/go-config-generator-for-fluentd-and-fluentbit@55d4fd2...8959c62
d-tux/udev@82fe5be...a12666f
didip/tollbooth@v3.0.2...v4.0.2
moby/moby@77e06fd...bd33bbf
prometheus/client_golang@v0.9.4...v1.7.1
prometheus/client_model@14fe0d1...v0.2.0
prometheus/common@v0.4.1...v0.10.0
https://cs.opensource.google/go/x/net/+/1bab6f366d9ec8c152f8735b2e359822ef75e3bd...refs/tags/v0.5.0
https://cs.opensource.google/go/x/sys/+/87e55d71481061dc6dcfb9a4953c896af893c130...refs/tags/v0.4.0
https://cs.opensource.google/go/x/tools/+/ef97713d99aa4e69742aa68fd45a63247b5d3ea0...refs/tags/v0.1.12
grpc/grpc-go@v1.48.0...v1.52.0
Note these are reverting to an older version in this commit:
golang/mock@v1.4.1...v1.6.0
bbolt is reverting from 1.3.6 to 1.3.5, it appears the 1.3.6 release tag was never promoted to a release and never will be in bbolt repo (see 'latest' release is 1.3.5): https://github.com/etcd-io/bbolt
etcd-io/bbolt@v1.3.5...v1.3.6
also see etcd-io/bbolt#326
Implementation details
Go modules were re-inited to fix build dependencies.
Backwards-incompatible package changes were mostly pinned to versions that don't require any changes to the agent codebase (except for minor changes in tollbooth and winio packages), so almost all changes in this PR are in the vendor/ directory.
The docker library pinning breaks windows builds though, so as a temporary fix one file in that docker client library for windows is manually pinned to the latest version via curl (see below).
The rest of the libraries will be updated in phases in follow-up PRs (and will require agent code changes).
temporary windows build fix:
Testing
unit tests, integ tests, functional tests
Description for the changelog
Enhancement: Update go version in module file, update most vendored build dependencies to latest library.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.