go mod and vendor update #3551
Merged
go mod and vendor update #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* go mod and vendor update * unit test upd * go mod tidy, go mod vendor on mac * try to fix windows winio dependency change in docker lib * hack: fix windows build * upgrade containernetworking/plugins * resolve some accidental downgrades * fix github actions
sparrc
force-pushed
the
go-mod-vendor-update-v3
branch
from
1071a0f to
9083ac2
Compare
golang.org/x/net/http/httpproxy changed it's behavior regarding the HTTP_PROXY and HTTPS_PROXY env vars. it was to fix this issue: golang/go#40909 and this is the change: https://go-review.googlesource.com/c/net/+/249440 After this change the HTTP_PROXY env var will be ignored for HTTPS requests, you have to also set HTTPS_PROXY in order for HTTPS requests from the agent to be proxied. This means that if there are customers setting HTTP_PROXY but not HTTPS_PROXY, their requests will no longer be proxied. Pin to an older version of the httpproxy package to avoid this behavior change. Copying the file in-repo so that we can upgrade the rest of golang.org/x/net without issue, and also so that any potential future uses of x/net/http/httpproxy do not collide with maintaining this previous desired behavior.
sparrc
force-pushed
the
go-mod-vendor-update-v3
branch
from
9083ac2 to
462356c
Compare
amogh09
approved these changes
Jan 30, 2023
mythri-garaga
approved these changes
Jan 30, 2023
ubhattacharjya
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3534, which was reverted because it caused a change in behavior in agent proxying behavior (see second commit message description).
This PR had long functional tests to verify all tests pass, including TestSquidProxy
Summary
Diffs of direct dependencies in go.mod file:
awslabs/go-config-generator-for-fluentd-and-fluentbit@55d4fd2...8959c62
d-tux/udev@82fe5be...a12666f
didip/tollbooth@v3.0.2...v4.0.2
moby/moby@77e06fd...bd33bbf
prometheus/client_golang@v0.9.4...v1.7.1
prometheus/client_model@14fe0d1...v0.2.0
prometheus/common@v0.4.1...v0.10.0
https://cs.opensource.google/go/x/net/+/1bab6f366d9ec8c152f8735b2e359822ef75e3bd...refs/tags/v0.5.0
https://cs.opensource.google/go/x/sys/+/87e55d71481061dc6dcfb9a4953c896af893c130...refs/tags/v0.4.0
https://cs.opensource.google/go/x/tools/+/ef97713d99aa4e69742aa68fd45a63247b5d3ea0...refs/tags/v0.1.12
grpc/grpc-go@v1.48.0...v1.52.0
Note these are reverting to an older version in this commit:
golang/mock@v1.4.1...v1.6.0
bbolt is reverting from 1.3.6 to 1.3.5, it appears the 1.3.6 release tag was never promoted to a release and never will be in bbolt repo (see 'latest' release is 1.3.5): https://github.com/etcd-io/bbolt
etcd-io/bbolt@v1.3.5...v1.3.6
also see etcd-io/bbolt#326
Implementation details
Go modules were re-inited to fix build dependencies.
Backwards-incompatible package changes were mostly pinned to versions that don't require any changes to the agent codebase (except for minor changes in tollbooth and winio packages), so almost all changes in this PR are in the vendor/ directory.
The docker library pinning breaks windows builds though, so as a temporary fix one file in that docker client library for windows is manually pinned to the latest version via curl (see below).
The rest of the libraries will be updated in phases in follow-up PRs (and will require agent code changes).
temporary windows build fix:
Testing
unit tests, integ tests, functional tests
Ran "long" functional tests, verified all tests (including TestSquidProxy) passed.
Description for the changelog
Enhancement: Update go version in module file, update most vendored build dependencies to latest library.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.