Telemetry test #357
Closed
Telemetry test #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response to a "docker exec". Update the event handling code to ignore these.
…askArn Extend the TaskEngine interface with the GetTaskByArn method
…nielrowles-wf/amazon-ecs-agent into danielrowles-wf-ignore-docker-1.8.3-exec-events
Sharing an instance of TestTime shares state across tests (things that called Sleep() or AfterFunc()). Switching to a per-test instance reduces shared state and seems to make TestSweepContainer more stable (at least on my computer).
This test is only reliable when the kernel properly supports memory and swap limits. If you try to limit memory on a system where the kernel does not support swap limits, the container can continue to use memory in swap well beyond the expected timeout of the test. If your system does not support swap limits, you'll see a message like the following when running a container with a memory limit: WARNING: Your kernel does not support swap limit capabilities, memory limited without swap. Note that you should not disable this test by default.
Starting with Docker 1.7.0, a `kill` event is emitted by the daemon on any signal sent to the container, rather than just on SIGKILL. In testing different Docker versions, a `die` event is emitted on all container exits (both Docker-initiated and container-initiated) and is a more reliable indicator. See aws#335
|
Can you recreate this against the |
edibble21
pushed a commit
to edibble21/amazon-ecs-agent
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added telemetry functional test.