Move AuditLogger interface to ecs-agent module #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
ohsoo
reviewed
Apr 25, 2023
ohsoo
previously approved these changes
Apr 25, 2023
ohsoo
previously approved these changes
Apr 25, 2023
fierlion
previously approved these changes
Apr 25, 2023
agent/go.mod
Outdated
| @@ -3,6 +3,7 @@ module github.com/aws/amazon-ecs-agent/agent | |||
| go 1.19 | |||
|
|
|||
| require ( | |||
| github.com/aws/amazon-ecs-agent/ecs-agent v0.0.0-00010101000000-000000000000 | |||
There was a problem hiding this comment.
nit: was this go.mod auto-generated via go mod (I assume it was)?
can this just be v0.0.0 since we're replacing it anyway?
There was a problem hiding this comment.
Yeah this was auto-generated. I will simplify this.
mythri-garaga
approved these changes
Apr 26, 2023
Merged
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 16, 2023
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving
AuditLoggerinterface to the newecs-agentmodule. The interface will be used in future functionality to be added toecs-agentmodule.Implementation details
AuditLoggerinterface and the correspondingLogRequeststruct toecs-agentmodule.agentmodule to not create mock implementation forAuditLoggerinterface.ecs-agentmodule to create mock implementation forAuditLoggerinterface inecs-agentmodule.ecs-agentto match the version used byagentmodule.agentdepend onecs-agentand update the usage ofAuditLoggerandLogRequestto import them fromecs-agentmodule instead.Testing
Built Agent from source and performed the following tests that both trigger audit logging.
/var/log/ecs/audit.logfile./var/log/ecs/audit.logfile.New tests cover the changes: no
Description for the changelog
Move AuditLogger interface to ecs-agent module.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.