Add tests for GetTaskProtection API to high-level TMDS tests #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
get-task-protection-tests
branch
2 times, most recently
from
289f51c
to
2549644
Compare
singholt
previously approved these changes
Jun 7, 2023
singholt
approved these changes
Jun 7, 2023
|
nit: For PR description, unless I'm misunderstanding, I think
should be replaced with
Changes themselves LGTM 👍 |
danehlim
approved these changes
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive unit tests for GetTaskProtection API to Task Metadata Server (TMDS) tests. These test cases are already covered by handler-level unit tests for GetTaskProtection handler, however, we will be moving the handler to ecs-agent module in upcoming PRs and having the API tested by TMDS tests will help gain confidence in the move.
This change is a part of a series of similar changes we have been making for many TMDS endpoints. See #3729, #3722, and #3708 that did the same for taskWithTags, task metadata, and container metadata endpoints, respectively.
Implementation details
NewTaskProtectionClientmethod ofTaskProtectionClientFactoryInterfaceinterface so that it can be mocked. This interface is used by task protection handlers to initialize ECS clients with the right permissions to make ECS task protection calls for the tasks.agent/handlers/task_server_setup.goto use dependency injection forTaskProtectionClientFactoryInterface.TestGetTaskProtectionfunction to TMDS test file. This function contains tests for GetTaskProtection API.Testing
New tests cover the changes: NA
Description for the changelog
Add tests for GetTaskProtection API to high-level TMDS tests
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.