Add tests for UpdateTaskProtection API to high-level TMDS tests #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
update-task-protection-tests
branch
from
5d76305
to
9beb80a
Compare
mye956
reviewed
Jun 8, 2023
mye956
reviewed
Jun 8, 2023
| } | ||
|
|
||
| // Test cases start here | ||
| t.Run("task ARN not found", func(t *testing.T) { |
There was a problem hiding this comment.
Q: Could we perhaps use/invoke a helper function here instead of having an anonymous function call for each test case? It seems like they're doing the same thing, only with the setStateExpectations, expectedStatusCode, and expectedResponseBody fields being different across test cases.
There was a problem hiding this comment.
It is a standard practice to pass an anonymous function to t.Run call. That being said, I have added a commit that adds a helper function for running a test case and populating path and method fields that are common across all test cases. All other fields have variations across test cases.
chienhanlin
approved these changes
Jun 9, 2023
Realmonia
approved these changes
Jun 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive unit tests for UpdateTaskProtection API to Task Metadata Server (TMDS) tests. These test cases are already covered by handler-level unit tests for UpdateTaskProtection handler, however, we will be moving the handler to ecs-agent module in upcoming PRs and having the API tested by TMDS tests will help gain confidence in the move.
This change is a part of a series of similar changes we have been making for many TMDS endpoints. See #3739, #3729, #3722, and #3708 that did the same for GetTaskProtection, taskWithTags, task metadata, and container metadata endpoints, respectively.
Implementation details
testTMDSRequestfunction andTMDSTestCasestruct to support request body and arbitrary HTTP method. This is because UpdateTaskProtection API expects a request body and PUT HTTP method.TestUpdateTaskProtectionfunction to TMDS test file. This function contains tests for UpdateTaskProtection API.TestAgentAPIV1UpdateTaskProtectionHandleras it is superseded byTestUpdateTaskProtection.Testing
New tests cover the changes: NA
Description for the changelog
Add tests for UpdateTaskProtection API to high-level TMDS tests
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.