Support for setting PIDs limit for ECS tasks #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
commented
Jul 7, 2023
| @@ -363,9 +363,10 @@ func (task *Task) PostUnmarshalTask(cfg *config.Config, | |||
|
|
|||
| task.adjustForPlatform(cfg) | |||
|
|
|||
| // TODO, add rudimentary plugin support and call any plugins that want to | |||
There was a problem hiding this comment.
this TODO was 8 years old....probably time to remove
sparrc
commented
Jul 7, 2023
| @@ -1,3 +1,6 @@ | |||
| //go:build unit | |||
There was a problem hiding this comment.
unrelated to this change, but these tests were not running without this tag
sparrc
commented
Jul 7, 2023
| assert.Equal(t, 0, parseTaskPidsLimit()) | ||
| } | ||
|
|
||
| func TestParseContainerInstanceTags(t *testing.T) { |
There was a problem hiding this comment.
this test is unrelated to this change, but am going to add a bunch of unrelated unit tests for the parse.go function that didnt previously exist
fierlion
reviewed
Jul 10, 2023
fierlion
previously approved these changes
Jul 10, 2023
chienhanlin
reviewed
Jul 10, 2023
chienhanlin
reviewed
Jul 10, 2023
sparrc
force-pushed
the
pids-limit
branch
2 times, most recently
from
d3f5bdc
to
03839b6
Compare
|
Do we need to update https://github.com/aws/amazon-ecs-agent/blob/dev/agent/config/parse_unsupported.go too? |
Realmonia
approved these changes
Jul 10, 2023
chienhanlin
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new agent configuration variable:
ECS_TASK_PIDS_LIMITThis variable defaults to being unset, which results in the current behavior of no PID limit being set at the task level.
If the user sets this to a value 1 or more, then agent will set the pids.max pid limit cgroup parameter to the provided value, for the task-level cgroup for all ECS tasks that are launched on this container instance. Note that this limit is applied for the whole task, not per-container.
addresses aws/containers-roadmap#354 for the EC2 launch type.
Implementation details
Testing
Functionality was verified manually and unit tests were added in this PR. Functional tests will be added before merging to dev branch.
New tests cover the changes: yes
Description for the changelog
Enhancement: ECS_TASK_PIDS_LIMIT for setting the task-level PIDs limit.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.