-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for setting PIDs limit for ECS tasks #3790
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
//go:build unit | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unrelated to this change, but these tests were not running without this tag |
||
// +build unit | ||
|
||
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"). You may | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package config | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestParseContainerInstanceTags(t *testing.T) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this test is unrelated to this change, but am going to add a bunch of unrelated unit tests for the parse.go function that didnt previously exist |
||
// empty | ||
t.Setenv("ECS_CONTAINER_INSTANCE_TAGS", "") | ||
var expected, actual map[string]string | ||
expectedErrs := []error{} | ||
actualErrs := []error{} | ||
actual, actualErrs = parseContainerInstanceTags(actualErrs) | ||
assert.Equal(t, expected, actual) | ||
assert.Equal(t, expectedErrs, actualErrs) | ||
// with valid values | ||
t.Setenv("ECS_CONTAINER_INSTANCE_TAGS", `{"foo":"bar","baz":"bin","num":"7"}`) | ||
expected = map[string]string{"baz": "bin", "foo": "bar", "num": "7"} | ||
expectedErrs = []error{} | ||
actual, actualErrs = parseContainerInstanceTags(actualErrs) | ||
assert.Equal(t, expected, actual) | ||
assert.Equal(t, expectedErrs, actualErrs) | ||
// with invalid values | ||
t.Setenv("ECS_CONTAINER_INSTANCE_TAGS", `{"foo":"bar","baz":"bin,"num":"7"}`) // missing " | ||
var expectedInvalid map[string]string | ||
expectedErrs = []error{fmt.Errorf("Invalid format for ECS_CONTAINER_INSTANCE_TAGS. Expected a json hash: invalid character 'n' after object key:value pair")} | ||
actual, actualErrs = parseContainerInstanceTags(actualErrs) | ||
assert.Equal(t, expectedInvalid, actual) | ||
assert.Equal(t, expectedErrs, actualErrs) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this TODO was 8 years old....probably time to remove