-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeStageVolume to common CSI client lib #3905
Conversation
dd40a8f
to
b73cac6
Compare
edadf33
to
d768083
Compare
d768083
to
db29121
Compare
golang.org/x/tools v0.6.0 | ||
github.com/stretchr/testify v1.8.2 | ||
golang.org/x/net v0.13.0 | ||
golang.org/x/sys v0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care if these versions here (i.e., golang.org/x/sys
, golang.org/x/tools
) mismatch with the ones used in agent module? I wonder if it would be best practice/beneficial to use the same versions of these between both agent and ecs-agent modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a follow-up tiny pr to fixup a couple of go module issues -- will add this as well. Good comment.
db29121
to
49a54d7
Compare
7cb882b
to
b6d2aac
Compare
b6d2aac
to
4b8742e
Compare
Summary
This Adds the
NodeStageVolume
function to the csiclient library and extracts the connection setup into a helper function.Implementation details
The client code is modeled after Kubernetes' CSI Client.
Testing
Tested via fierlion/NodeStageAltogether which includes the present CSI Client changes and CSI Driver updates from #3900 as well as hard-coded volume parameters in the task.go
New tests cover the changes: no
Description for the changelog
Add NodeStageVolume to common CSI client library.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.