Managed Daemon fixup #3910
Merged
Managed Daemon fixup #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
force-pushed
the
fierlion/ManagedDaemonFix
branch
3 times, most recently
from
8bf7489
to
54dd833
Compare
fierlion
changed the title
Realmonia
reviewed
Sep 18, 2023
fierlion
force-pushed
the
fierlion/ManagedDaemonFix
branch
from
54dd833
to
106d15b
Compare
Realmonia
approved these changes
Sep 18, 2023
mye956
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CSI Managed Daemon requires both privilege and mount propagation. This adds them to the Managed Daemon config and integrates this with
CreateDaemonTaskTesting
Added unit tests and also tested
Tested via fierlion/NodeStageAltogether which includes CSI Client changes from #3905 and CSI Driver updates from #3900 as well as hard-coded volume parameters in the task.go
New tests cover the changes: yes
Description for the changelog
Update Managed Daemon to allow for privilege and mount propagation.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.