Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: Increase start and create timeouts #696

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

samuelkarp
Copy link
Contributor

@samuelkarp samuelkarp commented Feb 3, 2017

Summary

Increases the timeout for start container to 3 minutes and create container to 4 minutes. Related to #682.

Testing

  • Builds on Linux (make release)
  • Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
  • Unit tests on Linux (make test) pass
  • Unit tests on Windows (go test -timeout=25s ./agent/...) pass
  • Integration tests on Linux (make run-integ-tests) pass
  • Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
  • Functional tests on Linux (make run-functional-tests) pass
  • Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes: no

Description for the changelog

Enhancement - Increase docker start and docker create timeouts to improve reliability under some workloads.

Licensing

This contribution is under the terms of the Apache 2.0 License: yes (Amazon employee)

Copy link
Contributor

@aaithal aaithal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should increase it by a minute for create as well.

@samuelkarp
Copy link
Contributor Author

@aaithal I don't have a strong opinion on that. Want me to bump that up too?

@aaithal
Copy link
Contributor

aaithal commented Feb 3, 2017

Yeah, just because we know that creates are more expensive than starts in terms of time. How does 4 * time.Minute sound?

@samuelkarp
Copy link
Contributor Author

@aaithal Done

@samuelkarp samuelkarp changed the title engine: Increase timeout for start container engine: Increase start and create timeouts Feb 3, 2017
@samuelkarp samuelkarp added this to the 1.14.1 milestone Feb 3, 2017
@samuelkarp samuelkarp merged commit 6a9584a into aws:dev Feb 8, 2017
@adnxn adnxn mentioned this pull request Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants