V1.14.1 release #723
Merged
V1.14.1 release #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adnxn
commented
Mar 6, 2017
adnxn
commented
- Enhancement - Log completion of image pulls. Log completion of image pulls. #715
- Enhancement - Increase start and create timeouts to improve reliability under some workloads. engine: Increase start and create timeouts #696
- Bug - Fixed a bug where throttles on state change reporting could lead to corrupted state. Ensure task status is reported before cleanup #705
- Bug - Correct formatting of log messages from tcshandler. Update tcshandler logging for seelog. #693
- Bug - Fixed an issue where agent could crash. Fix #570 #692
* Fix event state race condition in task engine unit tests. I think this originated from copying test code from a unit test that already had this bug because of the race condition. The deleted line of code used to result in race condition and it would trigger the task engine to do additional work after the test would complete leading to test failures. Should fix aws#669 * Vendor gomock with support for MinTimes * Add documentation for using MinTimes in TestTaskTransitionWhenStopContainerReturnsUnretriableError test
Travis now provides a feature that fixes the issue the hack script was working around.
Update tcshandler logging for seelog.
* Force steady state check in TestBatchContainerHappyPath. This should hopefully remove the flakiness reported in aws#662 * Refactor task engine tests to use testify and to extract the common createDockerEvent into a function of its own
Prior to this change, a race condition exists between reporting task status and task cleanup in the agent. If reporting task status took an excessively long time and ECS_ENGINE_TASK_CLEANUP_WAIT_DURATION is set very short, the containers and associated task metadata could be removed before the ECS backend is informed that the task has stopped. When the task is especially short-lived, it's also possible that the cleanup could occur before the ECS backend is even informed that the task is running. In this situation, it's possible for the ECS backend to re-transmit the task to the agent (assuming that it hadn't started yet) and the de-duplication logic in the agent can break. With this change, we ensure that the task status is reported prior to cleanup actually starting.
Fixes aws#686 Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
Fixes aws#698 Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
* This patch tests the happy paths of the custom-instance-attribute feature. The `ECS_INSTANCE_ATTRIBUTE` holds a set of key=value pairs which are exposed via the DescribeContainerInstances API. Each key or value can contain upto 128 characters and we currently only support a maximum of 10 custom attributes per instance. http://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_PutAttributes.html describes more details about the limits for the attributes. Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
Log completion of image pulls.
richardpen
reviewed
Mar 9, 2017
| some workloads. [#696](https://github.com/aws/amazon-ecs-agent/pull/696) | ||
| * Bug - Fixed a bug where throttles on state change reporting could lead to | ||
| corrupted state. [#705](https://github.com/aws/amazon-ecs-agent/pull/705) | ||
| * Bug - Correct formatting of log messages from tcshandler. [#693](https://github.com/aws/amazon-ecs-agent/pull/693) |
There was a problem hiding this comment.
I don't think we need to include the first one and this in the changelog, which is just helpful for debugging.
There was a problem hiding this comment.
I agree that we don't need to include everything in our changelog, but since this was an addition of a "debugging feature" it seemed worth including.
richardpen
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.