Fix test batch container happy path unit test #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully remove the flakiness reported in aws#662
…reateDockerEvent into a function of its own
This was referenced Feb 9, 2017
jwerak
pushed a commit
to appuri/amazon-ecs-agent
that referenced
this pull request
Jun 8, 2017
* Force steady state check in TestBatchContainerHappyPath. This should hopefully remove the flakiness reported in aws#662 * Refactor task engine tests to use testify and to extract the common createDockerEvent into a function of its own
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modifies the test batch container happy path unit test to be less flaky
Implementation details
DecribeContaineris invoked at-least once.docker_task_engine_test.gofile to useassert()s wherever possible.Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: N/A
Description for the changelog
None
Licensing
This contribution is under the terms of the Apache 2.0 License: Yes