Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent unit-test failure: TestBatchContainerHappyPath() #662

Closed
liwenwu-amazon opened this issue Jan 11, 2017 · 1 comment
Closed

Comments

@liwenwu-amazon
Copy link
Contributor

On Windows Platform, unit-test sometimes fails on TestBatchContainerHappyPath() testcase.

Here is the output of failure:
--- FAIL: TestBatchContainerHappyPath (0.01s)
controller.go:113: no matching expected call: *engine.MockDockerClient.DescribeContainer([containerId])

aaithal added a commit to aaithal/amazon-ecs-agent that referenced this issue Feb 9, 2017
This should hopefully remove the flakiness reported in aws#662
aaithal added a commit that referenced this issue Feb 9, 2017
* Force steady state check in TestBatchContainerHappyPath.

This should hopefully remove the flakiness reported in #662

* Refactor task engine tests to use testify and to extract the common createDockerEvent into a function of its own
@aaithal
Copy link
Contributor

aaithal commented Feb 9, 2017

Should be fixed with #703

@aaithal aaithal closed this as completed Feb 9, 2017
jwerak pushed a commit to appuri/amazon-ecs-agent that referenced this issue Jun 8, 2017
* Force steady state check in TestBatchContainerHappyPath.

This should hopefully remove the flakiness reported in aws#662

* Refactor task engine tests to use testify and to extract the common createDockerEvent into a function of its own
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants