V1.14.2 release #821
Merged
V1.14.2 release #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adnxn
commented
May 26, 2017
adnxn
commented
- Bug - Added checks for circular task dependencies. Check task dependencies before processing the task #796
- Bug - Fixed an issue with Docker auth configuration overrides. Fix the docker auth configuration overrides problem in #732 #751
- Bug - Fixed a race condition in the task clean up code path. Fix an race condition in agent #737
- Bug - Upgrade AWS SDK to v1.8.19 to include SDK bugfixes. Upgrading vendored AWS SDK release to v1.8.19 #786
- Bug - Fixed an issue involving concurrent map writes. Fix concurrent writes during image cleanup #743
This test regressed with PR aws#706. The original intent of the test was to test if gets exercised while a task is being cleaned up. This was accomplished by sending events to the engine's container event stream while cleanup was in progress using the mock client's method. However, we lost this part with PR#706. This commit adds that code back and removes some of the unnecessary code in .
This fixes all the outstanding TODO's to migrate the test code to using MinTimes instead of AnyTimes. Should resolve aws#429
…l test There's no need of this functional test for the following reasons: 1. TestRemoveEvents unit test covers this code path 2. TestTaskCleanupDoesNotDeadlock is leading to lots of false-negatives 3. Even when TestTaskCleanupDoesNotDeadlock succeeds, it's not guaranteed to execise the discardEventsUtil() method This should obfuscate the need for PR aws#749
This helps break up the humongous types.go file into more distinct, type-specific files. There are also minor renaming changes here, where a C_STYLE_CONST was renamed as a GoStyleConst and comments have been added as per Lint guidelines
1. Removed Container.SentStatus 2. Removed Task.UpdateKnownStatusAndTime as it's functionally equivalent to Task.SetKnownStatus 3. Moved TaskStatus methods from containerstatus to taskstatus
This helps in making it explicit that accessing these fields without locks is unsafe and hence discouraged
DockerAuth returned as an empty object(which is not nil) when it is not set from environment variable, which won't be overrides from contents read from file.
Multiple execution of recent windows unit test executions have resulted in timeout errors. Timing recent manual unit test executions on a windows platforms shows that they took between 19-23 seconds, which is really close to the 25s threshold. Increasing the timeout to 40s so that we don't run into timeout exceeded panic while executing windows unit tests
The task state in dockerstate and managed task in task manager are modified when task is added and cleaned up, both are protected by processTasks.Lock. But in cleanup the task state is modified outside the lock which could cause inconsistent state of the task in rare case.
…hods. This method has now been broken into: i. startContainerTransitions ii. onContainersUnableToTransitionState and iii. waitForContainerTransitions The main aim is to make this method more readable and testable. On that note, multiple unit tests have also been added to test each method that constitutes progressContainers()
This change is needed to support alternative URLs for per-region bucket support. The validation of Host and Location provide no extra security guarantees as the update's checksum is transmitted along with the location across a trusted communication channel and used to verify the download.
Testify's assertions clean this up considerably. The require.* funcs are needed to stop the test on assert failures. assert.* funcs are used only where the test can continue regardless of the assertion, despite the test being marked as a FAILure.
This patch improves clarity to the existing `ECS_INSTANCE_ATTRIBUTES`. It also points to additional documentation on AWS docs. Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
* Refactor http request code to use public API * Adding "codegen" build constraint * Regenerating ECS and ECR client code * Minor fixes
This change uses a single channel to propagate task and container transition events from the engine. Using a single channel forces container events to preceed task events for a given task transition.
This patch inspects the cleanup and resolves the inherent concurrent map write issue reported. An unit test has been added to increase confidence in the fix. Fixes aws#707 Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
aaithal
requested changes
May 26, 2017
CHANGELOG.md
Outdated
| * Bug - Added checks for circular task dependencies. [#796](https://github.com/aws/amazon-ecs-agent/pull/796) | ||
| * Bug - Fixed an issue with Docker auth configuration overrides [#751](https://github.com/aws/amazon-ecs-agent/pull/751) | ||
| * Bug - Fixed a race condition in the task clean up code path. [#737](https://github.com/aws/amazon-ecs-agent/pull/737) | ||
| * Bug - Upgrade AWS SDK to v1.8.19 to include SDK bugfixes [#786](https://github.com/aws/amazon-ecs-agent/pull/786) |
There was a problem hiding this comment.
I don't think this is a bug. In fact, I don't think we should call it out at all as it's not a customer facing thing.
There was a problem hiding this comment.
@aaithal which one exactly?
There was a problem hiding this comment.
Bug - Upgrade AWS SDK to v1.8.19 to include SDK bugfixes [#786]
aaithal
reviewed
May 26, 2017
CHANGELOG.md
Outdated
| * Bug - Fixed a race condition in the task clean up code path. [#737](https://github.com/aws/amazon-ecs-agent/pull/737) | ||
| * Bug - Upgrade AWS SDK to v1.8.19 to include SDK bugfixes [#786](https://github.com/aws/amazon-ecs-agent/pull/786) | ||
| * Bug - Fixed an issue involving concurrent map writes [#743](https://github.com/aws/amazon-ecs-agent/pull/743) | ||
|
|
There was a problem hiding this comment.
Also, you're missing the Enhancement to introspection API for querying task id's with short container ids #813
adnxn
force-pushed
the
v1.14.2-stage
branch
3 times, most recently
from
89d2fc6 to
3184b87
Compare
richardpen
approved these changes
May 26, 2017
aaithal
approved these changes
May 26, 2017
|
LGTM |
samuelkarp
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.