enable node events when instance type is not supported #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
May 8, 2023
jdn5126
approved these changes
May 8, 2023
haouc
added a commit
that referenced
this pull request
May 29, 2023
* add healthz subpathes for all controllers (#201) * support arch arg in dockerfile (#207) * updated vpc limits to include fields for hypervisor type and bare metal status (#217) * enable node events when instance type is not supported (#218) * Associate primary network interface SG with the trunk ENI when SG is not specified in ENIConfig (#221) * Associate primary network interface SG with the trunk ENI when SG is not specified in ENIConfig * add a new CRD to delegate vpc resource requests (#210) * upgrade controller runtime version (#227) * rebased onto master branch * fixed merge conflict --------- Co-authored-by: Hao Zhou <haouc@users.noreply.github.com> Co-authored-by: Sushmitha Ravikumar <58063229+sushrk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Since this controller runs in EKS control plane, if the instance type is not supported, the error message is not available for users. To make users' debugging easier and better visibility, we should expose some of critical failures that can be mitigated from user side. Events are common use for this purpose. This change propose sending node event when
Other changes:
Tests:
The unsupported and mocked missing instance types were used to test the events
case 1: the instance type doesn't support SGP/trunk interface
case 2: the (mocked) instance is new and hasn't been added into the supporting list
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.