Associate primary network interface SG with the trunk-eni when SG is not specified in ENIConfig #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #189
Description of changes:
Currently, when security group is not specified in ENIConfig, the trunk ENI is associated with the default security group of the VPC. The expected behavior when using vpc-cni >= v1.8.0 is to use the primary network interface security groups with secondary network interfaces.
Changes in this PR is to associate the trunk ENI with the primary network interface security groups when ENIConfig is missing security groups.
Testing:
In v1.1.5, the trunk ENI of the instance in
us-west-2b
is associated with the default security group of the VPC. Verified that with the changes in this PR the trunk ENI is associated with the primary network interface security groups.Also verified with correct ENIConfigs that the trunk ENI is associated with the SG specified in the ENIConfig
Release Notes:
This PR introduces a breaking change. Starting in v1.1.6+, when security groups are not specified in ENIConfig with custom networking enabled, the trunk ENI will be associated with the security group of the primary network interface rather than the default security group of the VPC.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.