Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workarounds from custom pod controller and refactor code #44

Merged
merged 6 commits into from
Aug 24, 2021

Conversation

abhipth
Copy link
Contributor

@abhipth abhipth commented Aug 12, 2021

Description of changes:

  • Removing workaround from the memory optimized Pod controller to pass Delete Event with request.
  • Renaming file and structs, interfaces names to more descriptive names.
  • Refactor code so it's easier to add new resource like IPv4 Address on top of Pod ENI.

Testing for the Change

  • Ran Integration test in loop (x5 times) - Passed
  • Ensure memory doesn't increase as the Number of Pods increases - Passed
  • Ensure existing Pod's networking is not removed once the controller restarts - Passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhipth abhipth requested a review from haouc August 17, 2021 16:45
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an authority on this code base. I looked it, trying to understand the change and adding comments.

Please take other reviewer's comments over mine.

controllers/core/pod_controller_test.go Show resolved Hide resolved
pkg/handler/handler.go Outdated Show resolved Hide resolved
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controllers/core/node_controller.go Show resolved Hide resolved
controllers/core/pod_controller.go Show resolved Hide resolved
controllers/custom/custom_controller.go Outdated Show resolved Hide resolved
controllers/custom/custom_controller.go Show resolved Hide resolved
pkg/k8s/wrapper.go Outdated Show resolved Hide resolved
@orsenthil
Copy link
Member

@abhipth - I am done reviewing. Please address these comments and I could review again and approve it.

@abhipth abhipth changed the base branch from master to release-1.1 August 23, 2021 18:19
@orsenthil
Copy link
Member

The unit tests failure is due to this upstream issue - kubernetes-sigs/kubebuilder#2311

@abhipth abhipth requested review from orsenthil and removed request for haouc August 23, 2021 23:50
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you.

controllers/core/pod_controller_test.go Show resolved Hide resolved
pkg/resource/manager.go Show resolved Hide resolved
@abhipth abhipth merged commit 0d81ed2 into aws:release-1.1 Aug 24, 2021
@abhipth abhipth deleted the completed-pod-fix branch August 24, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants