-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove workarounds from custom pod controller and refactor code #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an authority on this code base. I looked it, trying to understand the change and adding comments.
Please take other reviewer's comments over mine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
This https://github.com/aws/amazon-vpc-resource-controller-k8s/pull/44/files#r690825698 seems to be only significant comment that could change the code a little again.
-
Rest of the comments are to improve readability and comprehensibility.
-
There are unused local variables through out the code, perhaps linter will help remove them all.
@abhipth - I am done reviewing. Please address these comments and I could review again and approve it. |
The unit tests failure is due to this upstream issue - kubernetes-sigs/kubebuilder#2311 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you.
Description of changes:
Testing for the Change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.