Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 go.kubebuilder.io has broken for downloading kubebuilder releases #2311

Closed
FillZpp opened this issue Aug 23, 2021 · 14 comments · Fixed by #2321
Closed

🐛 go.kubebuilder.io has broken for downloading kubebuilder releases #2311

FillZpp opened this issue Aug 23, 2021 · 14 comments · Fixed by #2321
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@FillZpp
Copy link

FillZpp commented Aug 23, 2021

What broke? What's expected?

Failed to download kubebuilder releases, including:

https://go.kubebuilder.io/dl/2.3.1/linux/amd64
https://go.kubebuilder.io/dl/3.1.0/linux/amd64

But master is fine:

https://go.kubebuilder.io/dl/master/linux/amd64

Reproducing this issue

curl -L https://go.kubebuilder.io/dl/3.1.0/linux/amd64

KubeBuilder (CLI) Version

nil

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

@FillZpp FillZpp added the kind/bug Categorizes issue or PR as related to a bug. label Aug 23, 2021
@FillZpp
Copy link
Author

FillZpp commented Aug 23, 2021

/cc @camilamacedo86 @Adirio

@mugli
Copy link

mugli commented Aug 23, 2021

Experiencing the same with https://go.kubebuilder.io/dl/2.3.2/linux/amd64 too.

@AzureMarker
Copy link

Here's a short-term (or long-term?) fix from the linked PRs: Change the URL you use to
https://github.com/kubernetes-sigs/kubebuilder/releases/download/v${version}/kubebuilder_${version}_${os}_${arch}.tar.gz

Blokje5 added a commit to DataWorkz-NL/KubeETL that referenced this issue Aug 23, 2021
…igs/kubebuilder#2311

Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
arnobroekhof pushed a commit to DataWorkz-NL/KubeETL that referenced this issue Aug 23, 2021
* chore: reenable tests

* fix: Wrap get in eventually

* Fix: Found the culprits Eventually

* chore: Add empty readme

* chore: fix issues with golangcilint

Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>

* fix: Manually install kubebuilder from correct URL. see: kubernetes-sigs/kubebuilder#2311

Signed-off-by: Lennard Eijsackers <lennardeijsackers92@gmail.com>
@poadhika
Copy link

Experiencing the same with https://go.kubebuilder.io/dl/3.1.0/linux/amd64 too. The proposed short term fix works for version 2.3.1 but not for 3.1.0. Please advise.

@AzureMarker
Copy link

@poadhika it looks like they just removed the version from the filename: https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.1.0

@rashmigottipati
Copy link
Contributor

@poadhika
Copy link

@poadhika it looks like they just removed the version from the filename: https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.1.0

Yes removing the version solved my issue.

@camilamacedo86
Copy link
Member

HI folks,

The assets are available in the release page: https://github.com/kubernetes-sigs/kubebuilder/releases

https://github.com/kubernetes-sigs/kubebuilder/releases/download/v3.1.0/kubebuilder_linux_amd64

And you can curl this links. So, I do not understand why your trying to use:

https://go.kubebuilder.io/dl/2.3.1/linux/amd64
https://go.kubebuilder.io/dl/3.1.0/linux/amd64

Where did you check that links should be used?

@camilamacedo86 camilamacedo86 added the triage/needs-information Indicates an issue needs more information in order to work on it. label Aug 28, 2021
@AzureMarker
Copy link

@camilamacedo86 The go.kubebuilder.io links are from the documentation: https://book.kubebuilder.io/quick-start.html#installation

@camilamacedo86
Copy link
Member

camilamacedo86 commented Aug 30, 2021

Could you please help us out by pushing a PR for us to update it asap?
We should use the links in https://github.com/kubernetes-sigs/kubebuilder/releases/ e.g: https://github.com/kubernetes-sigs/kubebuilder/releases/download/v3.1.0/kubebuilder_linux_amd64 .

@joelanford @estroz,

Have you any idea why that worked in the past? Have we any reason for we need to make that link in the doc still working?

fspaniol added a commit to fspaniol/kubebuilder that referenced this issue Aug 31, 2021
I have not updated the `latest` option because it still works and I'm not sure how to get the latest version in this option.

Relates to kubernetes-sigs#2311
@fspaniol
Copy link

Hi @camilamacedo86 , I've opened. #2320, although I'm not sure it the change is good, any proposals would be welcome :)

@jmrodri
Copy link
Contributor

jmrodri commented Aug 31, 2021

@jmrodri
Copy link
Contributor

jmrodri commented Aug 31, 2021

The release artifacts changed.
For 2.3.1 notice the files have the version number

image

Starting with the 3.0 alpha release the filenames changed
image

@JohnStarich
Copy link

JohnStarich commented Sep 1, 2021

@estroz Our pipeline is failing today possibly a result of #2321.

The below curl worked yesterday. Hope this helps to reproduce:

$ curl -fL https://go.kubebuilder.io/dl/2.3.1/linux/amd64
curl: (22) The requested URL returned error: 404

Edit: Apologies. Just checked the original comment more closely and realized this is the exact same issue. Suffice it to say "my pipeline was affected". 🙂

Here's the fix I used for 2.3.1:

-	curl -L https://go.kubebuilder.io/dl/${KUBEBUILDER_VERSION}/$(shell go env GOOS)/$(shell go env GOARCH) | tar --strip-components=1 -xz -C ./cache/kubebuilder_${KUBEBUILDER_VERSION}; \
+	curl -L https://github.com/kubernetes-sigs/kubebuilder/releases/download/v${KUBEBUILDER_VERSION}/kubebuilder_${KUBEBUILDER_VERSION}_$(shell go env GOOS)_$(shell go env GOARCH).tar.gz | tar --strip-components=1 -xz -C ./cache/kubebuilder_${KUBEBUILDER_VERSION}; \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants