Bump k8s dependencies to 1.22 and go to 1.16 #496
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
@andrewsykim @lubronzhan can you give it a review when you get a chance? Thanks! |
k8s-ci-robot
added
the
lgtm
There was a problem hiding this comment.
@nicolehanjing this PR looks good overall, can we create a release-1.21 branch off of master first before merging this?
go.mod
Outdated
| k8s.io/api v0.22.0 | ||
| k8s.io/apiextensions-apiserver v0.22.0 // indirect | ||
| k8s.io/apimachinery v0.22.0 | ||
| k8s.io/client-go v0.22.0 |
There was a problem hiding this comment.
I think 1.22.1 just came out, wondering if we should use that.
There was a problem hiding this comment.
ah yes, let me update that
nicolehanjing
force-pushed
the
bump-go-version
branch
from
9670251
to
1aa4492
Compare
k8s-ci-robot
removed
the
lgtm
nicolehanjing
force-pushed
the
bump-go-version
branch
5 times, most recently
from
b199bfd
to
b68ed0c
Compare
|
/test pull-cloud-provider-vsphere-unit-test |
nicolehanjing
force-pushed
the
bump-go-version
branch
3 times, most recently
from
a0f7e94
to
dc0fbe2
Compare
Makefile
Outdated
| curl -L https://go.kubebuilder.io/dl/2.3.1/${GOOS}/${GOARCH} | tar -xz -C /tmp/ | ||
| mv /tmp/kubebuilder_2.3.1_${GOOS}_${GOARCH} /usr/local/kubebuilder | ||
| curl -L https://github.com/kubernetes-sigs/kubebuilder/releases/download/v2.3.1/kubebuilder_2.3.1_${os}_${arch}.tar.gz | tar -xz -C /tmp/ | ||
| sudo mv /tmp/kubebuilder_master_${GOOS}_${GOARCH} /usr/local/kubebuilder |
There was a problem hiding this comment.
Fix kubebuilder installation in workflow.
Caused by kubernetes-sigs/kubebuilder#2311
Fix was found here: https://github.com/operator-framework/operator-lifecycle-manager/pull/2335/files
nicolehanjing
force-pushed
the
bump-go-version
branch
from
dc0fbe2
to
6decabb
Compare
nicolehanjing
force-pushed
the
bump-go-version
branch
from
6decabb
to
179ef5f
Compare
I created a release-1.21 branch just now - I should create this branch when cutting the release, but probably my git remote setting was not right so the release branch didn't get pushed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lubronzhan, nicolehanjing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
Bump k8s dependencies to 1.22 and go to 1.16
The merge is blocked by a kubebuilder issue:
Fix kubebuilder installation in workflow.
Caused by kubernetes-sigs/kubebuilder#2311
Fix was found here: https://github.com/operator-framework/operator-lifecycle-manager/pull/2335/files
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: