Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manager.yaml #54

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Update manager.yaml #54

merged 2 commits into from
Jan 20, 2022

Conversation

albertogeniola
Copy link
Contributor

Upgrade resource limits to fix issue #52

Upgrade resource limits to fix to jetstack#52
@jakexks
Copy link
Contributor

jakexks commented Oct 5, 2021

Thanks for your contribution! The tests are failing for an unrelated reason so I will fix them and merge it.

@albertogeniola
Copy link
Contributor Author

Great to hear that. Keep up the great work!

@albertogeniola
Copy link
Contributor Author

Hi! Any news on this matter?

@nasirhm
Copy link

nasirhm commented Jan 18, 2022

I am facing the same issue, can we please have it merged.

@mattbates
Copy link
Contributor

mattbates commented Jan 19, 2022

@jakexks wdyt?

@maelvls
Copy link
Member

maelvls commented Jan 20, 2022

CI seems broken due to a breaking change in the https://go.kubebuilder.io/releases URL: kubernetes-sigs/kubebuilder#2311. Another issue was that the kubebuilder envtest assets (apiserver, etcd) were moved out from the kubebuilder release tarball (which is not a tarball anymore; it's a plain binary now). Finding where to download the envtest deps is painful. I think the "correct" way now is to install setup-envtest:

go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
setup-envtest use 1.22.x
eval $(setup-envtest use -i -p env 1.22.x)

Update: the project does not use envtest nor kubebuilder anyways, I'll remove that.

@maelvls
Copy link
Member

maelvls commented Jan 20, 2022

@jakexks Looking at the error

malformed secret key: separator '1' at invalid position: pos=-1, len=0

which comes from:

identity, err := age.ParseX25519Identity(os.Getenv("AGE_SECRET_KEY"))

I think the GitHub secret AGE_SECRET_KEY is not loaded in CI jobs coming from forks.

@maelvls maelvls merged commit 866fd90 into jetstack:main Jan 20, 2022
@maelvls
Copy link
Member

maelvls commented Jan 20, 2022

Since the CI works on main and that the issue is that GitHub secrets aren't loaded for forks (cf docs), I will manually merge this PR.

We shall find a solution for this though 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants