Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubebuilder installation in workflow #720

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Aug 24, 2021

Signed-off-by: FillZpp FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Fix kubebuilder installation in workflow.

Caused by kubernetes-sigs/kubebuilder#2311
Fix was found here: https://github.com/operator-framework/operator-lifecycle-manager/pull/2335/files

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Aug 24, 2021
@FillZpp FillZpp force-pushed the fix-kubebuilder-installation-in-workflow branch from f3f6e59 to c6b2410 Compare August 24, 2021 04:00
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/XS size/XS: 0-9 labels Aug 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #720 (8704a0b) into master (2aa99b3) will increase coverage by 0.48%.
The diff coverage is 59.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
+ Coverage   48.71%   49.20%   +0.48%     
==========================================
  Files          99       99              
  Lines        9055     8969      -86     
==========================================
+ Hits         4411     4413       +2     
+ Misses       3967     3893      -74     
+ Partials      677      663      -14     
Flag Coverage Δ
unittests 49.20% <59.25%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/daemonset/update.go 25.51% <0.00%> (ø)
...g/webhook/pod/validating/pod_unavailable_budget.go 62.31% <ø> (ø)
...g/controller/statefulset/statefulset_controller.go 23.70% <16.66%> (ø)
...controller/broadcastjob/broadcastjob_controller.go 54.72% <42.30%> (-0.03%) ⬇️
pkg/controller/daemonset/daemonset_controller.go 35.16% <72.72%> (+2.26%) ⬆️
pkg/controller/daemonset/daemonset_util.go 67.21% <75.00%> (+10.33%) ⬆️
pkg/controller/broadcastjob/broadcastjob_utils.go 50.00% <100.00%> (ø)
...kg/controller/daemonset/daemonset_event_handler.go 76.69% <100.00%> (ø)
pkg/controller/statefulset/stateful_pod_control.go 100.00% <100.00%> (ø)
...troller/statefulset/stateful_set_status_updater.go 84.61% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42992e0...8704a0b. Read the comment docs.

Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
@FillZpp FillZpp force-pushed the fix-kubebuilder-installation-in-workflow branch from c6b2410 to 8704a0b Compare August 24, 2021 05:59
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furykerry furykerry merged commit 8a10ff5 into openkruise:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants