-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 fix(netlify): fix broken redirect resource #2321
📖 fix(netlify): fix broken redirect resource #2321
Conversation
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
@estroz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/cherry-pick book-v3 |
The release redirect rule uses a self-defined JS handler function because releases prior to v3 had a different URL structure not handle-able by Netlify's static redirect definitions. The handler checks for a
releases
resource path component in the request URL, which doesn't exist in the event path provided to the handler (the API may have changed, not sure of the cause). This PR explicitly adds this resource path component to the redirect URL.Closes #2320
Closes #2311
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com