Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 fix(netlify): fix broken redirect resource #2321

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Aug 31, 2021

The release redirect rule uses a self-defined JS handler function because releases prior to v3 had a different URL structure not handle-able by Netlify's static redirect definitions. The handler checks for a releases resource path component in the request URL, which doesn't exist in the event path provided to the handler (the API may have changed, not sure of the cause). This PR explicitly adds this resource path component to the redirect URL.

Closes #2320
Closes #2311

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 31, 2021

/cc @joelanford @camilamacedo86

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2021
@joelanford
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 31, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@estroz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-19-4 eac4386 link /test pull-kubebuilder-e2e-k8s-1-19-4

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@estroz
Copy link
Contributor Author

estroz commented Aug 31, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit b6c94ab into kubernetes-sigs:master Aug 31, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 31, 2021

/cherry-pick book-v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 go.kubebuilder.io has broken for downloading kubebuilder releases
3 participants