Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 WIP: docs: configure redirects to work from any host on which the site is running #2314

Closed

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Aug 24, 2021

This PR also attempts to fix the ongoing issues with redirects that fail for kubebuilder artifact downloads.

…running

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joelanford
To complete the pull request process, please assign pwittrock after the PR has been reviewed.
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@estroz
Copy link
Contributor

estroz commented Aug 30, 2021

@joelanford did this recently break? setup-envtest still seems to work fine.

@joelanford
Copy link
Member Author

It's still failing for me:

$ curl -sSL -D - https://go.kubebuilder.io/dl/2.3.2/linux/amd64 -o /dev/null

HTTP/2 301
cache-control: public, max-age=0, must-revalidate
content-length: 68
content-type: text/plain; charset=utf-8
date: Mon, 30 Aug 2021 19:41:34 GMT
x-nf-request-id: 01FEC99KK7HMF9C9REGWN9627R
age: 0
location: https://go.kubebuilder.io/releases/2.3.2/linux/amd64
server: Netlify

HTTP/2 404
cache-control: public, max-age=0, must-revalidate
content-type: text/html; charset=utf-8
date: Mon, 30 Aug 2021 19:41:34 GMT
etag: 1546572965-ssl
server: Netlify
age: 0
x-nf-request-id: 01FEC99KP1K41NXZ474M54HH42

@joelanford
Copy link
Member Author

Closed by #2321

@joelanford joelanford closed this Sep 1, 2021
@joelanford joelanford deleted the docs-fix-redirects branch September 1, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants