Update README.md #86
Closed
Update README.md #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added '--profile' flag details and changed interval to sampling interval for clarity.
|
This change in README should also have a corresponding change in the "--help" text source code. Not done in this PR. |
wash-amzn
reviewed
Oct 13, 2023
|
|
||
| `-p, --period` period (how long you want the data collection to run, default is 10s) | ||
|
|
||
| `-r, --run-name` run name (name of the run for organization purposes, creates directory of the same name, default of aperf_[timestamp]) | ||
|
|
||
| `-v, --verbose` verbose messages | ||
|
|
||
| `--profile` Gather profiling data using the 'perf' library |
There was a problem hiding this comment.
In between two verbose arguments is a strange place to have dropped this
There was a problem hiding this comment.
Yes, I felt so too. The ./aperf record --help has it so I just copied to keep that order. Indeed this should be fixed in both places.
There was a problem hiding this comment.
You can change both in the same PR ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added '--profile' flag details and changed interval to sampling interval for clarity.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.