Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #86

Closed
wants to merge 2 commits into from
Closed

Update README.md #86

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3241118
Update README.md
RamaMalladiAWS Oct 13, 2023
c897029
Merge branch 'aws:main' into main
RamaMalladiAWS Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,15 @@ To see a step-by-step example, please see our example [here](./EXAMPLE.md)

`-V, --version` version of APerf

`-i, --interval` interval collection rate (default 1)
`-i, --interval` sampling interval collection rate (default 1)

`-p, --period` period (how long you want the data collection to run, default is 10s)

`-r, --run-name` run name (name of the run for organization purposes, creates directory of the same name, default of aperf_[timestamp])

`-v, --verbose` verbose messages

`--profile` Gather profiling data using the 'perf' library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In between two verbose arguments is a strange place to have dropped this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I felt so too. The ./aperf record --help has it so I just copied to keep that order. Indeed this should be fixed in both places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change both in the same PR ;)


`-vv, --verbose --verbose` more verbose messages

Expand Down
Loading