fix: mysql support #115
Merged
fix: mysql support #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
failover_with_mysql
branch
4 times, most recently
from
0dc017f
to
66dd82a
Compare
karenc-bq
commented
Sep 1, 2023
| @@ -54,7 +54,7 @@ jobs: | |||
|
|
|||
| - name: 'Run Integration Tests' | |||
| run: | | |||
| ./gradlew --no-parallel --no-daemon test-all-environments --info | |||
| ./gradlew --no-parallel --no-daemon test-mysql-aurora --info | |||
There was a problem hiding this comment.
Temporary change to run integration tests
karenc-bq
force-pushed
the
failover_with_mysql
branch
7 times, most recently
from
0863fd1
to
10a864a
Compare
karenc-bq
force-pushed
the
mysql-integration
branch
3 times, most recently
from
d9a3ff4
to
0827b5b
Compare
karenc-bq
force-pushed
the
failover_with_mysql
branch
from
ed2b4ca
to
d6aa0b0
Compare
congoamz
reviewed
Sep 12, 2023
| ] | ||
|
|
||
| def is_network_exception(self, error: Optional[Exception] = None, sql_state: Optional[str] = None) -> bool: | ||
| if isinstance(error, QueryTimeoutError): |
There was a problem hiding this comment.
Does MySQL have a ConnectionTimeoutError that we should check for like PG? Or is the connection timeout caught in the logic below?
There was a problem hiding this comment.
| @@ -55,6 +55,16 @@ class FailoverPlugin(Plugin): | |||
| "force_connect", | |||
| "notify_host_list_changed"} | |||
|
|
|||
| _METHODS_REQUIRE_UPDATED_TOPOLOGY: Set[str] = { | |||
| "Connection.commit", | |||
There was a problem hiding this comment.
how did we come up with this method list, and why is it necessary?
There was a problem hiding this comment.
Mysql specific thing awslabs/aws-mysql-jdbc#364
aws_wrapper/failover_plugin.py
Outdated
| @@ -408,6 +419,9 @@ def _allowed_on_closed_connection(method_name: str): | |||
| method_name == "Connection.getSchema" or \ | |||
| method_name == "Connection.getTransactionIsolation" | |||
|
|
|||
| def _can_update_topology(self, method_name: str): | |||
There was a problem hiding this comment.
would _requires_topology_update be a more accurate name? to me can_update_topology makes it sound like the methods listed above (commit, rollback etc) can cause a topology update in and of themselves
karenc-bq
force-pushed
the
mysql-integration
branch
from
0827b5b
to
841fcd8
Compare
karenc-bq
force-pushed
the
failover_with_mysql
branch
4 times, most recently
from
f3aab9f
to
301407a
Compare
karenc-bq
force-pushed
the
mysql-integration
branch
from
841fcd8
to
6907ba0
Compare
karenc-bq
force-pushed
the
failover_with_mysql
branch
from
301407a
to
30c9fcc
Compare
karenc-bq
force-pushed
the
failover_with_mysql
branch
from
30c9fcc
to
a00c45d
Compare
karenc-bq
added a commit
that referenced
this pull request
Sep 20, 2023
karenc-bq
added a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.