Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only update topology for specific methods #364

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

karenc-bq
Copy link
Contributor

Summary

fix: only update topology for specific network bounded methods to not interrupt important workflows, e.g. fetching large dataset.

resolves #363

Description

  • Rename internal method to match the functionality.
  • Specify a list of methods where it is safe to update topology before running. Certain methods are executed during specific workflows, e.g., ResultSet#next is executed when the driver is potentially fetching more rows from the server with a streaming result set. When driver attempts to create a new statement object to fetch topology statement, errors may throw because the connection object may not have two opened streaming result sets at once.

Additional Reviewers

… interrupt important workflows, e.g. fetching large dataset.
@karenc-bq karenc-bq self-assigned this Feb 28, 2023
"connect",
"isValid",
"rollback",
"sendQueryCancel",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelling a query sounds like an emergency action for a user app and I wouldn't do any topology update when it happens.

"sendQueryCancel",
"setAutoCommit",
"setReadOnly",
"cancel",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar thoughts as above.

@karenc-bq karenc-bq marked this pull request as ready for review March 2, 2023 00:07
@karenc-bq karenc-bq merged commit 79a55a4 into awslabs:main Mar 2, 2023
@karenc-bq karenc-bq deleted the issue_363_fetch_topology branch March 2, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream query error
2 participants