Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-glue): Job construct #12443

Closed
1 of 2 tasks
humanzz opened this issue Jan 10, 2021 · 7 comments · Fixed by #12506
Closed
1 of 2 tasks

(aws-glue): Job construct #12443

humanzz opened this issue Jan 10, 2021 · 7 comments · Fixed by #12506
Labels
@aws-cdk/aws-glue Related to AWS Glue effort/large Large work item – several weeks of effort feature/new-construct A request for a new L2 construct feature-request A feature should be added or improved. p1

Comments

@humanzz
Copy link
Contributor

humanzz commented Jan 10, 2021

In #5172 and its PRs, the suggestion was made to break a PR down into 2

  1. Add Connection construct
  2. Add Job construct

I've since had a look and realized the work needed involves 3 constructs

  1. Connection construct (aws-glue): add Connection construct #12442
  2. SecurityConfiguration construct (aws-glue): add SecurityConfiguration construct #12449
  3. Job construct (this request)

Since the original issue and PR have gone without progress for a time, I am contributing some effort here and as such will be creating 3 issues and hopefully 3 PRs to address each of the issues.

This is the first issue; to add the Glue Job construct

Use Case

Be able to create Glue jobs with L2 constructs that utilize Glue connections. My immediate use case is to be able to connect data sources in a VPC

Proposed Solution

Introduce a Job L2 construct wrapping the Glue Job CloudFormation resource

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@humanzz humanzz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2021
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Jan 10, 2021
@humanzz humanzz changed the title (aws-glue): Add Job L2 construct Add Glue Job construct Jan 10, 2021
@humanzz humanzz changed the title Add Glue Job construct (aws-glue): Add Glue Job construct Jan 10, 2021
@iliapolo iliapolo added effort/large Large work item – several weeks of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2021
@humanzz humanzz changed the title (aws-glue): Add Glue Job construct (aws-glue): add Job construct Jan 10, 2021
@humanzz
Copy link
Contributor Author

humanzz commented Jan 15, 2021

@iliapolo there are now 3 PRs ready for review

@iliapolo
Copy link
Contributor

@humanzz amazing, thanks so much for these PR's. Should we start with the Connection construct PR?

@humanzz
Copy link
Contributor Author

humanzz commented Jan 15, 2021

@iliapolo I'd say either Connection or SecurityConfiguration are good to start with, or even both in parallel as they're independent.

Job has dependencies on both, so for it to be complete both PRs will have to be merged first. It's currently kinda complete but for using them and I anticipate it will take some reviewing/discussion as it's not a small one.

@straygar
Copy link

straygar commented Feb 5, 2021

Thanks @humanzz , super excited to see this merged! 🔥

@humanzz humanzz changed the title (aws-glue): add Job construct (aws-glue): Job construct Feb 15, 2021
@ericzbeard ericzbeard added the feature/new-construct A request for a new L2 construct label Apr 2, 2021
@maddy2u
Copy link

maddy2u commented May 31, 2021

Any update on this?

@tdikland
Copy link
Contributor

Would love to see this merged. Anything I can help with?

@iliapolo iliapolo removed their assignment Jun 27, 2021
@mergify mergify bot closed this as completed in #12506 Sep 8, 2021
mergify bot pushed a commit that referenced this issue Sep 8, 2021
Closes #12443

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue effort/large Large work item – several weeks of effort feature/new-construct A request for a new L2 construct feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants