Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-glue): add SecurityConfiguration construct #12449

Closed
1 of 2 tasks
humanzz opened this issue Jan 10, 2021 · 1 comment · Fixed by #12450
Closed
1 of 2 tasks

(aws-glue): add SecurityConfiguration construct #12449

humanzz opened this issue Jan 10, 2021 · 1 comment · Fixed by #12450
Assignees
Labels
@aws-cdk/aws-glue Related to AWS Glue effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@humanzz
Copy link
Contributor

humanzz commented Jan 10, 2021

In #5172 and its PRs, the suggestion was made to break a PR down into 2

  1. Add Connection construct
  2. Add Job construct

I've since had a look and realized the work needed involves 3 constructs

  1. Connection construct (aws-glue): add Connection construct #12442
  2. SecurityConfiguration construct (this request)
  3. Job construct (aws-glue): Job construct #12443

Since the original issue and PR have gone without progress for a time, I am contributing some effort here and as such will be creating 3 issues and hopefully 3 PRs to address each of the issues.

This is the first issue; to add the Glue SecurityConfiguration construct

Use Case

Be able to create Glue jobs with L2 constructs that utilize Glue connections. My immediate use case is to be able to connect data sources in a VPC

Proposed Solution

Introduce a SecurityConfiguration L2 construct

Other

I have to say that I found the CloudFormation documentation challenging - no clear default behaviours - and I based my work on the following links

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@humanzz humanzz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2021
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Jan 10, 2021
@humanzz humanzz changed the title (aws-glue): Add Glue SecurityConfiguration construct (aws-glue): add SecurityConfiguration construct Jan 10, 2021
@iliapolo iliapolo added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2021
@mergify mergify bot closed this as completed in #12450 Feb 15, 2021
mergify bot pushed a commit that referenced this issue Feb 15, 2021
Closes #12449

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
Closes aws#12449

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants