Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(custom-resources): use lambda.Runtime.NODEJS_12_X by default in Provider #13225

Closed
2 tasks done
trivikr opened this issue Feb 23, 2021 · 1 comment · Fixed by #13488
Closed
2 tasks done

(custom-resources): use lambda.Runtime.NODEJS_12_X by default in Provider #13225

trivikr opened this issue Feb 23, 2021 · 1 comment · Fixed by #13488
Assignees
@rix0rrr
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2

Comments

@trivikr
Copy link
Member

trivikr commented Feb 23, 2021

EvaluateExpression currently uses lambda.Runtime.NODEJS_10_X by default.

aws-cdk/packages/@aws-cdk/aws-stepfunctions-tasks/lib/evaluate-expression.ts

Line 61 in e628a73

this.evalFn = createEvalFn(this.props.runtime || lambda.Runtime.NODEJS_10_X, this);

Use lambda.Runtime.NODEJS_12_X instead

Use Case

Reasons for recommending NODEJS_12_X:

  • Node.js 12.x went LTS in October 2019, and has been actively supported since October 2020.
  • Node.js 10.x is going end-of-life on April 30th, 2021

https://endoflife.date/nodejs

Proposed Solution

Use lambda.Runtime.NODEJS_12_X by default in Provider

Other

Discussed at #12808 (comment)

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@trivikr trivikr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2021
@github-actions github-actions bot added @aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/custom-resources Related to AWS CDK Custom Resources labels Feb 23, 2021
@trivikr trivikr mentioned this issue Feb 23, 2021
Closed
@nija-at nija-at removed the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 23, 2021
@nija-at nija-at removed their assignment Feb 23, 2021
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 labels Feb 24, 2021
@emi-fukuta emi-fukuta mentioned this issue Mar 9, 2021
Closed
@iliapolo iliapolo mentioned this issue Mar 9, 2021
Merged
@mergify mergify bot closed this as completed in #13488 Mar 15, 2021
mergify bot pushed a commit that referenced this issue Mar 15, 2021
@rix0rrr
fix: use NodeJS 14 for all packaged custom resources (#13488)
20a2820 
NodeJS 10 is reaching end of life soon, it's time to move to NodeJS 14.

Fixes #13225 
Fixes #13534
Fixes #13484

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@pkwarren pkwarren mentioned this issue Feb 23, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use NodeJS 14 for all packaged custom resources aws/aws-cdk
3 participants
@rix0rrr @trivikr @nija-at