chore: use lambda.Runtime.NODEJS_12_X in all tests #12808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trivikr
force-pushed
the
use-lambda-NODEJS_12_X-in-cdk-tests
branch
3 times, most recently
from
7c64c89
to
70fdeef
Compare
nija-at
changed the title
nija-at
previously requested changes
Feb 23, 2021
packages/@aws-cdk/aws-stepfunctions-tasks/lib/evaluate-expression.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/custom-resources/lib/provider-framework/provider.ts
Outdated
Show resolved
Hide resolved
trivikr
force-pushed
the
use-lambda-NODEJS_12_X-in-cdk-tests
branch
from
70fdeef
to
430dec5
Compare
mergify
bot
dismissed
nija-at’s stale review
Pull request has been modified.
This was referenced Feb 23, 2021
Closed
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Why not go directly for |
I believe CloudFormation does not yet support inline code for Node 14. (I've not tested this personally) |
nija-at
suggested changes
Feb 25, 2021
|
Packaged custom resources were moved to nodejs 14.x in #13488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12713
This PR uses lambda.Runtime.NODEJS_12_X in CDK tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license