-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-elasticloadbalancingv2: health and unhealthy threshold counts can vary #26941
Comments
I can't find any docs on the topic, and neither the PR or the issue it fixed linked to any docs either. I'm not sure that your CLI output shows that the values can differ. Can you use escape hatches to set the values manually and see if it deploys? Or link to docs that states the values can differ? |
My apologies -- I copy/pasted the output from the wrong target group. Here is the output for a target group with differing thresholds:
|
Great, thanks! |
@peterwoodworth I'll take this. |
…ld counts (#26949) `HealthyThresholdCount` and `UnhealthyThresholdCount` do not need to be the same. In fact, the [docs](https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html#health-check-settings) have their default values as 5 and 2. Closes #26941. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
…ld counts (#26949) `HealthyThresholdCount` and `UnhealthyThresholdCount` do not need to be the same. In fact, the [docs](https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html#health-check-settings) have their default values as 5 and 2. Closes #26941. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The
validateTargetGroup
method in theNetworkTargetGroup
class has a check to ensure the healthy and unhealthy threshold counts are the same (https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts#L262-L268), but this does not appear to be a requirement of AWS.Expected Behavior
The
NetworkTargetGroup
is createdCurrent Behavior
An error message of
Healthy and Unhealthy Threshold Counts must be the same
.Reproduction Steps
Create a
NetworkTargetGroup
with differing healthy and unhealthy threshold counts.Possible Solution
Remove https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts#L262-L268
Additional Information/Context
No response
CDK CLI Version
2.91.0
Framework Version
No response
Node.js Version
18.17.1
OS
macOS 13.5.1
Language
Python
Language Version
3.9.16
Other information
No response
The text was updated successfully, but these errors were encountered: