Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticloadbalancingv2): remove equality check for health threshold counts #26949

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Aug 30, 2023

HealthyThresholdCount and UnhealthyThresholdCount do not need to be the same.

In fact, the docs have their default values as 5 and 2.

Closes #26941.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2023 19:47
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Aug 30, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review August 30, 2023 20:23

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@msambol msambol changed the title fix(elasticloadbalancingv2): remove equality check for threshold counts fix(elasticloadbalancingv2): remove equality check for health threshold counts Aug 30, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e523dc4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c8b8f1c into aws:main Aug 31, 2023
17 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 31, 2023
@msambol msambol deleted the ebv2-threshold-counts branch August 31, 2023 11:52
mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
…ld counts (#26949)

`HealthyThresholdCount` and `UnhealthyThresholdCount` do not need to be the same.

In fact, the [docs](https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html#health-check-settings)  have their default values as 5 and 2.

Closes #26941.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@msambol msambol restored the ebv2-threshold-counts branch November 21, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-elasticloadbalancingv2: health and unhealthy threshold counts can vary
3 participants