(aws-dms): Tags.of(CfnReplicationConfig construct).add({...}) does not work

[gossandr]

Describe the bug

When attempting to add Tags to the CfnReplicationConfig construct, no tags are actually added.

Furthermore, removing the Tags.of() and re-deploying the stack results in an error (presumably from the DMS API?).

Tags.of() does work for other constructs in aws-dms. For example, for the CfnEndpoint construct Tags.of() works as expected.

Expected Behavior

I would expect the tags to be added to the resource.

I would expect after removing Tags.of from the resource construct that I would not get any deployment errors.

Current Behavior

after adding Tags.of() and deploying, no tags are deployed on the replication config resource.

after then removing the Tags.of() and re-deploying, the deploy fails with this error, perhaps related to the dms API itself.

Resource handler returned message: "No modifications requested for replication
config with arn, 'arn:aws:dms:eu-west-1:259363291751:replication-config:RTQ7JQX
ZPNBOBJFNHAVMWAJXLWS35IWZOID6VAI' (Service: DatabaseMigration, Status Code: 400
, Request ID: 2248b0dc-8583-4b56-8f20-5381c630c8f0)" (RequestToken: c316768f-94
3b-0a97-d2ed-550977a3729d, HandlerErrorCode: GeneralServiceException)

Reproduction Steps

export class DmsReplication extends Construct {

  constructor(scope: Construct, id: string, props: DmsReplicationProps) {
    super(scope, id);

    const replication = new CfnReplicationConfig(this, 'rc01', {

      replicationType: 'full-load',


      sourceEndpointArn: 'arn:of:source:endpoint',
      targetEndpointArn: 'arn:of:target:endpoint',

    });
    
    
    Tags.of(replication).add('test', 'value');
  }

Possible Solution

I suspect that this is related to the relative new-ness of the serverless replication support in cloudformation. But I have honestly no idea. 😅

Additional Information/Context

No response

CDK CLI Version

2.123.0 (build a594112)

Framework Version

No response

Node.js Version

v18.2.0

OS

macos Ventura 13.6.3 (22G436)

Language

TypeScript

Language Version

TypeScript 5.2.2

Other information

No response

[pahud]

I think the tags of CfnReplicationConfig is probably mis-typed. It should be tags?: cdk.TagManager; instead.

    /**
     * One or more optional tags associated with resources used by the AWS DMS Serverless replication.
     */
    tags?: Array<cdk.CfnTag>;

[gossandr]

@pahud my understanding with the L1 Construct that they are essentially generated from the cloudformation spec. So in the code you show above -- where did you find that? 😅

I noticed in the cloudformation spec a slight difference in how Tags is defined between the AWS::DMS::Endpoint type and the AWS::DMS::ReplicationConfig type.

The ReplicationConfig Tags definition looks like this:

        "Tags": {
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dms-replicationconfig.html#cfn-dms-replicationconfig-tags",
          "UpdateType": "Mutable",
          "Required": false,
          "Type": "List",
          "ItemType": "Tag",
          "DuplicatesAllowed": true
    }

while the AWS::DMS::Endpoint looks like this:

        "Tags": {
          "Type": "List",
          "Required": false,
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dms-endpoint.html#cfn-dms-endpoint-tags",
          "ItemType": "Tag",
          "UpdateType": "Mutable"
        },

Not sure if this is relevant, but it is as far as I was able to get to understanding why this is happening

[GavinZZ]

After investigation, the above schema mentioned above are both valid since tags formatted like [ { Key: 'MyTag', Value: 'MyValue' } ] and tags formatted like { MyTag: MyValue } are both valid. It seems that we accidentally forced the flag HAS_25610 to be false.

This results in that ITaggableV2 interfaces not getting implemented for CFN resource of modern styled tagging property, which resulted in Tags.of ... not working. I'm going to push a simple fix to this issue and should not cause any breaking change at all.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[gossandr]

Thanks @GavinZZ and CDK team!