Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): a number of resources are not taggable with Tags.of() #28989

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Feb 5, 2024

Issue # (if applicable)

Closes #28862

Reason for this change

CFN resources that has array format tags cannot use Tags.of() to add tags.

Description of changes

Enable modern style tags ITaggableV2

Description of how you validated changes

The generated looks correct and shouldn't cause breaking changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the bug This issue is a bug. label Feb 5, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 5, 2024 16:02
@github-actions github-actions bot added effort/medium Medium work item – several days of effort p1 labels Feb 5, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 5, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ GavinZZ changed the title feat(spec2cdk): enable modern tagging style with ITaggableV2 chore(spec2cdk): enable modern tagging style with ITaggableV2 Feb 5, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 5, 2024 16:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 5, 2024

What we usually do is phrase the PR title as user-visible changes (because the PR titles make it into the CHANGELOG). Since this fixes a bug, I would do something like:

fix(core): a number of resources are not taggable with `Tags.of()`

@GavinZZ GavinZZ changed the title chore(spec2cdk): enable modern tagging style with ITaggableV2 fix(core): a number of resources are not taggable with Tags.of() Feb 5, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Feb 5, 2024

Exemption Request
No existing test suite for spec2cdk tool.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 5, 2024
@GavinZZ GavinZZ added the pr-linter/exempt-test The PR linter will not require test changes label Feb 5, 2024
@GavinZZ GavinZZ marked this pull request as ready for review February 5, 2024 18:51
@GavinZZ GavinZZ added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Feb 6, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 6, 2024 03:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Feb 8, 2024

@mergify update

Copy link
Contributor

mergify bot commented Feb 8, 2024

update

✅ Branch has been successfully updated

@GavinZZ GavinZZ requested a review from rix0rrr February 10, 2024 15:08
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 10, 2024
@gossandr
Copy link
Contributor

Any update on this? I am looking forward to a new release ;-)

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Feb 22, 2024

@gossandr Will try to get this merged this week.

@gossandr
Copy link
Contributor

@GavinZZ if you need any assistance, i might be able to help

Copy link
Contributor

mergify bot commented Feb 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 23, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5cce6f5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7a4c189 into main Feb 23, 2024
15 checks passed
@mergify mergify bot deleted the yuanhaoz/tagv2 branch February 23, 2024 10:50
Copy link
Contributor

mergify bot commented Feb 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-dms): Tags.of(CfnReplicationConfig construct).add({...}) does not work
4 participants