eks: Support latest AWS Load Balancer Controller versions #31082
Labels
@aws-cdk/aws-eks
Related to Amazon Elastic Kubernetes Service
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
arlampin
added
feature-request
github-actions
bot
added
the
@aws-cdk/aws-eks
ashishdhingra
added
investigating
|
Per https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases and https://github.com/aws/eks-charts/blob/v0.0.178/stable/aws-load-balancer-controller/Chart.yaml, the latest ALB controller version as of now is |
ashishdhingra
added
p2
effort/small
ashishdhingra
added
effort/medium
|
PR WIP #29959 |
3 tasks
mergify bot
pushed a commit
that referenced
this issue
Sep 4, 2024
As #29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes #31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. |
pahud
added a commit
to pahud/aws-cdk
that referenced
this issue
Sep 9, 2024
As aws#29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes aws#31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao
pushed a commit
to xazhao/aws-cdk
that referenced
this issue
Sep 12, 2024
As aws#29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes aws#31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ
pushed a commit
that referenced
this issue
Sep 12, 2024
As #29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes #31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
The latest controller version is 2.8.2, but CDK only supports versions up to 2.6.2. Also, both 2.7.x and 2.8.x have some changes to reference IAM policies, so using them is not just a matter of increasing version number.
Use Case
I would like to use the latest controller version
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.151.0
Environment details (OS name and version, etc.)
N/A
The text was updated successfully, but these errors were encountered: