chore(eks): add new ALB controller versions #29959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
distinguished-contributor
1 task
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
hey @nmussy, I spoke with @colifran about how we can test these changes and I think for unit tests we could just test the new versions being added like in #27910, but ideally I'd like to turn those tests into parameterized tests so that we can test all of the supported versions instead of just replacing what was used previously with the newly added versions. And for integ tests, I think it would be sufficient to just use the newly added version in the existing integ test case as seen here: https://github.com/aws/aws-cdk/pull/25330/files#r1179285561. Let me know if that makes sense to you or if you have any other quetions! |
This was referenced Apr 26, 2024
pahud
added
the
response-requested
|
This PR has been stale for more than 2 months. I am adding a response-requested label on it. @nmussy do you have any updates on this? |
github-actions
bot
removed
the
response-requested
|
Hey @pahud, I'd completely forgotten about this PR. I'm going to be unavailable for a week or so, but I definitely intend on adding integrations to this PR when I get back 👍 |
pahud
added
the
pr-linter/do-not-close
This was referenced Aug 30, 2024
|
As this PR has been stale for a while, I submitted yet another PR #31264 and is ready for review. |
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
As #29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes #31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
pahud
added a commit
to pahud/aws-cdk
that referenced
this pull request
Sep 9, 2024
As aws#29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes aws#31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao
pushed a commit
to xazhao/aws-cdk
that referenced
this pull request
Sep 12, 2024
As aws#29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes aws#31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ
pushed a commit
that referenced
this pull request
Sep 12, 2024
As #29959 has been stale for a while, I am submitting this PR to follow up. ### Issue # (if applicable) Closes #31082 ### Reason for this change ### Description of changes iam policy files were downloaded using this script ```sh #!/bin/bash versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2") target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons" for version in "${versions[@]}"; do url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json" filename="alb-iam_policy-v${version}.json" target_file="${target_dir}/${filename}" echo "Downloading ${url} to ${target_file}" curl -s "${url}" -o "${target_file}" done ``` helm repo updated using ```sh helm repo add eks https://aws.github.io/eks-charts helm repo update helm search repo aws-load-balancer-controller --versions --output json ``` get the app_version and helm version mapping using ```sh $ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"' v2.8.2 1.8.2 v2.8.1 1.8.1 v2.8.0 1.8.0 v2.7.2 1.7.2 v2.7.1 1.7.1 v2.7.0 1.7.0 ``` ### Description of how you validated changes - [x] parameterized tests in the unit tests - [x] using the latest version in the integ test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Closing this as #31264 has already been merged. |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None as far as I could tell
Follow up to the reverted #29470
Reason for this change
Update the CDK listed ALB controller versions to match the current availability
Description of changes
Description of how you validated changes
I listed the list of available versions by using the
ecr:ListImagescommand on theamazon/aws-load-balancer-controllerrepository. I'm also filtering out tags that do not match av1.2.3pattern, e.g.v2.0.0-rc5,v2.0.0-test-linux_amd64For the Helm chart version, I use the Helm CLI to obtain the corresponding versions, which worked a ton better and was easily integrated to my tool:
I'll update/add integ tests, pending maintainer feedback
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license