-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(route53): Vpc endpoint service private dns #10780
feat(route53): Vpc endpoint service private dns #10780
Conversation
…le domains on a single endpoint service
rix0rrr opined this should be in the route53 module - #10580 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flemjame-at-amazon took a first pass, take a look at the suggestions/feedback and let me know what you think!
- what's the added
newFile.ts
inaws-route53-patterns
- can that be removed? - an integration test needs to be added for
VpcEndpointServiceDomainName
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/test/vpc-endpoint-service-domain-name.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-route53-patterns/lib/vpc-endpoint-service-domain-name.ts
Outdated
Show resolved
Hide resolved
I'm not sure how that got in, must have misclicked - yes it will be removed.
Can you elaborate on what an integration test is? Do you mean an integ.vpc-endpoint-service-domain-name.test.ts coupled with an integ.expected.json ? |
…nd remove file accidentally created and added
Pull request has been modified.
Yes, running the integ test by
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flemjame-at-amazon looks good to me! added the do-not-merge
so @rix0rrr can also have one final look.
Pull request has been modified.
Linting rule: Fenced code blocks should be surrounded by blank lines
@shivlaks do you know what's happening with this? |
checking on it, hoping to get it merged ahead of the next release |
dropping the |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
https://aws.amazon.com/premiumsupport/knowledge-center/vpc-private-dns-name-endpoint-service/ https://docs.aws.amazon.com/vpc/latest/userguide/verify-domains.html AWS added the ability to specify a custom DNS name for an endpoint service earlier this year. It makes it so your clients don't have to create aliases for an InterfaceVpcEndpoint when they connect to your service. This reduces undifferentiated lifting done by clients. This PR creates a construct that will set up the custom DNS. ```ts stack = new Stack(); vpc = new Vpc(stack, 'VPC'); nlb = new NetworkLoadBalancer(stack, 'NLB', { vpc, }); vpces = new VpcEndpointService(stack, 'VPCES', { vpcEndpointServiceLoadBalancers: [nlb], }); // You must use a public hosted zone so domain ownership can be verified zone = new PublicHostedZone(stack, 'PHZ', { zoneName: 'aws-cdk.dev', }); new VpcEndpointServiceDomainName(stack, 'EndpointDomain', { endpointService: vpces, domainName: 'my-stuff.aws-cdk.dev', publicZone: zone, }); ``` Original design ticket: aws#10580 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vpcEndpointServiceLoadBalancers: [nlb], | ||
}); | ||
// You must use a public hosted zone so domain ownership can be verified | ||
zone = new PublicHostedZone(stack, 'PHZ', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be even better if we can import a hosted zone from different account by providing IAM access. DNS delegation may have been set up in a central account.
https://aws.amazon.com/premiumsupport/knowledge-center/vpc-private-dns-name-endpoint-service/
https://docs.aws.amazon.com/vpc/latest/userguide/verify-domains.html
AWS added the ability to specify a custom DNS name for an endpoint service earlier this year. It makes it so your clients don't have to create aliases for an InterfaceVpcEndpoint when they connect to your service. This reduces undifferentiated lifting done by clients. This PR creates a construct that will set up the custom DNS.
Original design ticket: #10580
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license